CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2018-11-09T22:11:38Zhttps://lab.civicrm.org/dev/core/-/issues/326Fatal error 'DB Error: no such field' on Contribution detail report when sect...2018-11-09T22:11:38ZPradeep Nayakpradpnayak@gmail.comFatal error 'DB Error: no such field' on Contribution detail report when section header enabledError code : Database Error Code: Unknown column 'civicrm_contribution_total_amount' in 'field list', 1054
![Peek_2018-08-14_16-19](/uploads/519bfa9483886f0ef2df276e76d1eb80/Peek_2018-08-14_16-19.gif)
Issue filed on stackexchange : ht...Error code : Database Error Code: Unknown column 'civicrm_contribution_total_amount' in 'field list', 1054
![Peek_2018-08-14_16-19](/uploads/519bfa9483886f0ef2df276e76d1eb80/Peek_2018-08-14_16-19.gif)
Issue filed on stackexchange : https://civicrm.stackexchange.com/questions/26124/db-error-missing-field-in-contribution-reports-after-upgrade-to-5-4-0-drupal/261265.5.0https://lab.civicrm.org/dev/core/-/issues/277Recurring contribution tab shouldn't count test transactions2018-07-31T22:12:11ZPradeep Nayakpradpnayak@gmail.comRecurring contribution tab shouldn't count test transactions![Screenshot_from_2018-07-24_13-27-48](/uploads/4ec1bca56c36f0c71cf2b7694662bde6/Screenshot_from_2018-07-24_13-27-48.png)
PR at https://github.com/civicrm/civicrm-core/pull/12553![Screenshot_from_2018-07-24_13-27-48](/uploads/4ec1bca56c36f0c71cf2b7694662bde6/Screenshot_from_2018-07-24_13-27-48.png)
PR at https://github.com/civicrm/civicrm-core/pull/125535.5.0https://lab.civicrm.org/dev/core/-/issues/273"Recipient phone number is invalid or recipient does not want to receive SMS"...2018-08-18T21:44:11Zjyothi"Recipient phone number is invalid or recipient does not want to receive SMS" error and Contacts with DoNotSms preference failing to filter out during Mass Sms in 5.x"Recipient phone number is invalid or recipient does not want to receive SMS" error occurs during individual SMS. https://civicrm.stackexchange.com/questions/25478/clickatell-sms-recipient-phone-number-is-invalid-or-recipient-does-not-wa..."Recipient phone number is invalid or recipient does not want to receive SMS" error occurs during individual SMS. https://civicrm.stackexchange.com/questions/25478/clickatell-sms-recipient-phone-number-is-invalid-or-recipient-does-not-want-to.
Contacts marked as 'donotsms' is not filtered out during mass SMS.5.5.0https://lab.civicrm.org/dev/core/-/issues/255Changes to copied event location reflects in original event location2019-02-05T04:25:52ZyashodhaChanges to copied event location reflects in original event locationSteps to replicate:
1. Create an event X with location A.
2. Create copy of event X say Y and go to location tab for event Y (which will now show location A).
3. Click *Create new location* radio and then click *Use existing location*, ...Steps to replicate:
1. Create an event X with location A.
2. Create copy of event X say Y and go to location tab for event Y (which will now show location A).
3. Click *Create new location* radio and then click *Use existing location*, choose option B.
4. Check event X also has location B.5.5.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/241Fix Manage Premiums UI2018-07-12T23:12:09Zmattwiremjw@mjwconsult.co.ukFix Manage Premiums UIRef: https://github.com/civicrm/civicrm-core/pull/12436
Manage premiums UI was not displaying the financial type correctly (it was showing the ID). The PR does the following:
1. Enable pseudoconstant for financial_type_id.
2. Use pseud...Ref: https://github.com/civicrm/civicrm-core/pull/12436
Manage premiums UI was not displaying the financial type correctly (it was showing the ID). The PR does the following:
1. Enable pseudoconstant for financial_type_id.
2. Use pseudoconstant functions to get the financial_type label (name) for display.
3. Format the money fields using crmMoney.
4. Add the cost field to the UI (normally I'd do this as a separate PR but it would be more work to break out the template changes and given how flaky/old the premiums code seems to be I suspect it's not actually being used by very many people - also it's only affecting an admin screen by displaying existing information).5.5.0https://lab.civicrm.org/dev/core/-/issues/228Option group disabled on update2018-07-11T00:47:58ZajesamsonOption group disabled on updateWhen updating option group attributes (excluding `is_active`), the updated option group gets disabled. This is because option group was [defaulted](https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/OptionGroup.php#L95) to ...When updating option group attributes (excluding `is_active`), the updated option group gets disabled. This is because option group was [defaulted](https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/BAO/OptionGroup.php#L95) to `FALSE` when adding or updating record without specifying desired `is_active` status.
![option_group](/uploads/d8291f18e46149d5852335749ca473e3/option_group.gif)
The desired result would have been leaving the `is_active` status untouched, if not required to be updated during attributes update.5.5.0https://lab.civicrm.org/dev/core/-/issues/223Expose prefix and suffix in reports2018-07-24T00:24:18ZyashodhaExpose prefix and suffix in reportsAdd prefix and suffix to *getContactColumns* method.Add prefix and suffix to *getContactColumns* method.5.5.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/219Improve consistency displaying "Test Transactions"2018-07-24T19:41:11Zmattwiremjw@mjwconsult.co.ukImprove consistency displaying "Test Transactions"There are currently a number of inconsistencies with displaying test transactions:
1. There is either no indication, or it is not obvious that you are viewing a test contribution/recur/membership when viewing the details.
2. Test members...There are currently a number of inconsistencies with displaying test transactions:
1. There is either no indication, or it is not obvious that you are viewing a test contribution/recur/membership when viewing the details.
2. Test memberships do not appear in the contact membership tab, but test contributions/recurring contributions do.
Proposal:
1. Add some "help" text that appears above the entity detail when viewing the entity if it is a test transaction.
2. Show test memberships in contact membership tab so it is consistent with other tabs.5.5.0https://lab.civicrm.org/dev/core/-/issues/218On Case Type listing page, for reserved ones the, 'More' link doesn't show an...2018-07-09T22:42:08ZMonish DebOn Case Type listing page, for reserved ones the, 'More' link doesn't show any optionsSteps to replicate:
1. Enable CiviCase component.
2. Go to Administer >> CiviCase >> Case Types
3. Click on 'More' action against any reserved Case type
![test-multiple-before](/uploads/c14d32b041c69c2b9c1941615214d1ac/test-multiple-befo...Steps to replicate:
1. Enable CiviCase component.
2. Go to Administer >> CiviCase >> Case Types
3. Click on 'More' action against any reserved Case type
![test-multiple-before](/uploads/c14d32b041c69c2b9c1941615214d1ac/test-multiple-before.gif)
**Proposal**:
Show the 'More' action only when
1. the case type is not reserved because then you have 'Delete' and Enable/Disable action OR
2. If case-type is reserved then show the more action only if the case-type is forked and/or disable, because then you got 'Revert' and/or 'Enable' option to show5.5.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/188Fix Floating Point Precision Comparison Exception on Order Creation2018-07-15T23:12:07ZCamilo RodríguezFix Floating Point Precision Comparison Exception on Order Creation## Overview
When adding Orders, a check is done by CiviCRM core when the contribution is being created to make sure the sum of line item totals is equal to the contribution total amount. This comparison, however, is done comparing floati...## Overview
When adding Orders, a check is done by CiviCRM core when the contribution is being created to make sure the sum of line item totals is equal to the contribution total amount. This comparison, however, is done comparing floating point values, which may fail falsely, under some circumstances.
This is the line where the comparison is done:
https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/BAO/Contribution.php#L5011
This problem is documented in PHP official documentation, and is actually related to the way floating point values are modeled in programming languages in general.
http://php.net/manual/en/language.types.float.php
http://floating-point-gui.de/basic/
This has to be taken into account to make sure the comparison doesn't fail when it shouldn't.
## How it Works Currently
1. Use API to try to create Order with given sample data.
2. Exception is thrown, saying "Line item total doesn't match with total amount".
## How it Should Work
1. Use API to try to create Order with given sample data.
2. Order is created without throwing exception.
## Sample Data
```
data ={
'contact_id': 1051,
'payment_instrument_id': 6,
'line_items': [{
'line_item': {
'0': {
'price_field_value_id': 56,
'price_field_id': 33,
'entity_id': 646,
'tax_amount': 0,
'line_total': 14.85,
'label': 4,
'entity_table': 'civicrm_membership',
'unit_price': 14.85,
'qty': 1}}}, {
'line_item': {
'1': {
'price_field_value_id': 55,
'price_field_id': 32,
'entity_id': 648,
'tax_amount': 0,
'line_total': 1.66,
'label': 50,
'entity_table': 'civicrm_membership',
'unit_price': 1.66,
'qty': 1}}}, {
'line_item': {
'2': {
'price_field_value_id': 49,
'price_field_id': 26,
'entity_id': 647,
'tax_amount': 0,
'line_total': 0.16,
'label': 47,
'entity_table': 'civicrm_membership',
'unit_price': 0.16,
'qty': 1}}}],
'total_amount': 16.67,
'financial_type_id': 2,
'fee_amount': 0,
'payment_processor_id': 5,
'receive_date': '2017-10-16',
'contribution_status_id': 1
}
```
## Failing API Call Example
Calling API using cv:
```
echo '{"contact_id":45,"payment_instrument_id":6,"line_items":[{"line_item":{"6":{"price_field_value_id":52,"price_field_id":29,"tax_amount":0,"line_total":14.85,"financial_type_id":2,"qty":1,"entity_table":"civicrm_membership","unit_price":14.85,"label":5}}},{"line_item":{"7":{"price_field_value_id":53,"price_field_id":30,"tax_amount":0,"line_total":1.66,"financial_type_id":2,"qty":1,"entity_table":"civicrm_membership","unit_price":1.66,"label":49}}},{"line_item":{"8":{"price_field_value_id":49,"price_field_id":26,"tax_amount":0,"line_total":0.16,"financial_type_id":2,"qty":1,"entity_table":"civicrm_membership","unit_price":0.16,"label":47}}}],"tax_amount":0,"total_amount":16.67,"contribution_recur_id":733,"financial_type_id":2,"fee_amount":0,"payment_processor_id":5,"receive_date":"2017-12-15","contribution_status_id":1}' | cv api Order.create --in=json
```5.5.0https://lab.civicrm.org/dev/core/-/issues/176Odd / Even street number sorting column missing from Reports2018-07-06T22:11:10Zjoels341Odd / Even street number sorting column missing from ReportsWhen trying to make a walk list in reports (odd/even street numbers), there is no option to sort by odd or even. I am using Civicrm in English on Joomla.
The French demo on Drupal has "Numéro de rue pair/impair" in the "column" dropdown...When trying to make a walk list in reports (odd/even street numbers), there is no option to sort by odd or even. I am using Civicrm in English on Joomla.
The French demo on Drupal has "Numéro de rue pair/impair" in the "column" dropdown, but I do not see it in the English version.![street-number](/uploads/f74556e4b99a646ee3aa1c9fdaacd96c/street-number.jpg)5.5.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/155Improvements and bugfixes to Option Groups UI2018-12-15T23:10:58Zmattwiremjw@mjwconsult.co.ukImprovements and bugfixes to Option Groups UI**Bugfix:**
Allow saving of new option value with value = 0.
PR (**MERGED**): https://github.com/civicrm/civicrm-core/pull/12229
**Additional fields on OptionGroup list**
This adds Enabled/Reserved columns to list and puts buttons at t...**Bugfix:**
Allow saving of new option value with value = 0.
PR (**MERGED**): https://github.com/civicrm/civicrm-core/pull/12229
**Additional fields on OptionGroup list**
This adds Enabled/Reserved columns to list and puts buttons at the top as well.
PR: https://github.com/civicrm/civicrm-core/pull/12233
![localhost_8000_civicrm_admin_options_reset_1](/uploads/e742132345fd2c7119f1fe3996a6a1d9/localhost_8000_civicrm_admin_options_reset_1.png)
**Resolve issues with use of "is_reserved" database field**
As the is_reserved flag is not being shown in the UI, and is not editable from the UI it has not been used for anything in core even though it is there.
A common use-case is adding an option group and then adding a set of custom fields that use that option group (eg. for surveys) but that is currently not possible via the UI because the query that looks for available option groups is looking ONLY for option groups that are already linked to custom fields - a catch 22!
PR: https://github.com/civicrm/civicrm-core/pull/12235
![customfieldoptiongroup](/uploads/85ef8c8ecf9826f94acedda058a7aa14/customfieldoptiongroup.png)5.5.0https://lab.civicrm.org/dev/core/-/issues/150Chain select for country/state in Search Builder does not stay within OR grou...2018-07-17T06:54:34ZAndie HuntChain select for country/state in Search Builder does not stay within OR groupingsdev/core#142 introduces a chained select for picking states from countries and picking counties from states. The changes there correctly limit the chaining to be within the same location type. However, picking a country will modify *al...dev/core#142 introduces a chained select for picking states from countries and picking counties from states. The changes there correctly limit the chaining to be within the same location type. However, picking a country will modify *all* state/province fields of that location type, even if they're in different "Also include contacts where" sections.
To recreate, let's say you are planning an event in Detroit:
1. Search for contacts in Michigan:
```
Contacts | Country | Home | = | United States
Contacts | State | Home | = | Michigan
```
2. Search for contacts in Ontario by clicking "Also include contacts where" and setting up:
```
Contacts | Country | Home | = | Canada
Contacts | State | Home | = | Ontario
```
Notice that the state dropdown where Michigan had been selected now has nothing selected and offers only Canadian provinces.
The same thing happens if you have a state field on its own (without country) and you pick a country in another `OR` grouping.5.5.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/141Custom groups with different names but same title would not be saved2018-07-14T01:25:44ZjaapjansmaCustom groups with different names but same title would not be savedI have created two custom groups from within my extension:
* Name: group_areas, Title: Areas
* Name: contact_areas, Title: Areas
When I now edit the custom group it will fail because both custom groups have the same title but a differe...I have created two custom groups from within my extension:
* Name: group_areas, Title: Areas
* Name: contact_areas, Title: Areas
When I now edit the custom group it will fail because both custom groups have the same title but a different name.
Is this correct behaviour?
See this stack exchange question: https://civicrm.stackexchange.com/questions/25102/https-civicrm-org-extensions-areas-causing-error/25104#25104
Tested on CiviCRM version 5.0.0 and CiviCRM version 5.1.aplha15.5.0https://lab.civicrm.org/dev/core/-/issues/93Update CRM_Utils_Rule::mysqlOrderBy() to accommodate more than 2 joins2018-11-10T00:41:10ZDon WijesooriyaUpdate CRM_Utils_Rule::mysqlOrderBy() to accommodate more than 2 joinsCurrently sorting only allows up to 2 joins: "membership_id.contact_id". If we go up a further level like "membership_id.contact_id.contact_type" it throws an error.
I suggest changing the regex:
```foreach ($parts as $part) {
...Currently sorting only allows up to 2 joins: "membership_id.contact_id". If we go up a further level like "membership_id.contact_id.contact_type" it throws an error.
I suggest changing the regex:
```foreach ($parts as $part) {
if (!preg_match('/^((`[\w-]{1,64}`|[\w-]{1,64})\.)?(`[\w-]{1,64}`|[\w-]{1,64})( (asc|desc))?$/i', trim($part))) {
return FALSE;
}
}```
to:
```/^((`[\w-]{1,64}`|[\w-]{1,64})\.)```{+ + +}```?(`[\w-]{1,64}`|[\w-]{1,64})( (asc|desc))?$/i```5.5.0https://lab.civicrm.org/dev/core/-/issues/34Split edit/view access on permissioned relationships2023-04-28T01:39:33Zaydunsaidan.saunders@squiffle.ukSplit edit/view access on permissioned relationshipsCurrently, relationships can be 'permissioned' such that one contact in the relationship can access the other. This access is both view and edit. It is not possible to provide 'view-only' access via a relationship.
The proposed approa...Currently, relationships can be 'permissioned' such that one contact in the relationship can access the other. This access is both view and edit. It is not possible to provide 'view-only' access via a relationship.
The proposed approach is to create an 'edit related contacts' permission that works in conjunction with the existing permissioning:
- for users with the 'edit related contacts' permission, behaviour is unchanged
- for users without the 'edit related contacts' permission, contacts that they have access to via permissioned relationships will be viewable (as now), but not editable (change).5.5.0aydunsaidan.saunders@squiffle.ukaydunsaidan.saunders@squiffle.uk