CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2021-10-02T05:27:54Zhttps://lab.civicrm.org/dev/core/-/issues/348Custom Participant tokens not working in scheduled reminders2021-10-02T05:27:54Zmagnolia61Custom Participant tokens not working in scheduled remindersCustom Participant tokens do not work in scheduled reminders.<BR>
I believe the underlying code exists in CiviCRM but it is not possible to use participant tokens.
Work has been done to get these working in pdf creation though: https://...Custom Participant tokens do not work in scheduled reminders.<BR>
I believe the underlying code exists in CiviCRM but it is not possible to use participant tokens.
Work has been done to get these working in pdf creation though: https://issues.civicrm.org/jira/browse/CRM-16734
20200902 Coming back at this issue. I tested again and these are the results using CiviCRM 5.28.4<br>
Situation is an event registration and scheduled reminders being send based on that.
| Type of token | example | result |
| ------ | ------ | ------ |
| Only core event tokens | event.title | get correctly replaced |
| Custom event tokens | event.custom_123| Expected one Event but found 0 |
| Only core participant tokens | participant.role | No error, but do not get replaced |
| Custom participant tokens | participant.custom_123 | No error, but do not get replaced |5.43.0justinfreeman (Agileware)justinfreeman (Agileware)https://lab.civicrm.org/dev/core/-/issues/365Unwanted mail blast sent by Scheduled Reminders2021-06-10T07:04:39Zmagnolia61Unwanted mail blast sent by Scheduled Reminders**BUG 1:**<br>
I enabled a scheduled reminder which was configured to sent 12 week before the start date of an event.
The start date was a month ago on july 21st.
* Expected behavior: no mail is being sent.
* Actual behaviour: 500 famil...**BUG 1:**<br>
I enabled a scheduled reminder which was configured to sent 12 week before the start date of an event.
The start date was a month ago on july 21st.
* Expected behavior: no mail is being sent.
* Actual behaviour: 500 families got an email with the last details on the event (that already happened).
Over the last few years we have had more incidents like these and it really hurts our reputation, and within our organization it also hurts the reputation of CiviCRM.
The scheduled reminders should be way more clear in configuration and unintentional mail blast should really be prevented by good tests and more solid code.
For this particular issue I would suggest to NOT send a reminder that is configured BEFORE an event, AFTER the event. This could be configured in Civi/ActionSchedule/RecipientBuilder.php although I lack the skills to figure out how.
**BUG 2**<br>
Also what happened is that the reminder was configured for specific participant statuses and it ignored that and sent it anyway to participants with any status. Should be solved but also a test should be introduced for this.
**BUG 3**<br>
The limit to group function seems (sometimes) to be ignored when sending to participants (selected by event type). Should be solved but also a test should be introduced for this.
**CONCLUSION**<BR>
I will further test on clean install, but to me this seems to be critical bugs as they
1) have a reputation impact<br>
2) might impact spam ratings<br>
3) cause a lot of work to follow up (send rectifications, responding to responses by mail)...
....5.39.0https://lab.civicrm.org/dev/core/-/issues/2535Improve scheduled reminder UI for selection of event specific date or time be...2022-10-01T14:07:07ZlarsssandergreenImprove scheduled reminder UI for selection of event specific date or time before eventTo set a scheduled reminder for an event, you can either set it to a specific date or n hours, days, etc before the event. However, the UI to set these two options is confusing. If you set a date and n hours before, the n hours before is...To set a scheduled reminder for an event, you can either set it to a specific date or n hours, days, etc before the event. However, the UI to set these two options is confusing. If you set a date and n hours before, the n hours before is ignored. The user must click the X beside the date to remove it in order to make the second option work, which is non-standard and confusing (I had a staff member save a reminder multiple times who couldn't figure out why the n hours before option was disappearing).
![image](/uploads/860d004144b394d04c3d68bd92287ef6/image.png)
To make this clearer to users, I suggest adding radio buttons in front of the two options and only using the selected option.5.55.0https://lab.civicrm.org/dev/core/-/issues/2541Clarify scheduled reminder options: Event Start Date -> Event Start, etc2021-04-28T04:27:09ZlarsssandergreenClarify scheduled reminder options: Event Start Date -> Event Start, etcSmall detail, but the options to send a scheduled reminder relative to an event are a little confusing.
![image](/uploads/5841527fcac9d04f62ea81190743bf99/image.png)
If you set a reminder for 4 hours before the "Event Start Date", does...Small detail, but the options to send a scheduled reminder relative to an event are a little confusing.
![image](/uploads/5841527fcac9d04f62ea81190743bf99/image.png)
If you set a reminder for 4 hours before the "Event Start Date", does that mean it is sent four hours before the start of the event (this is what happens) or 4 hours before 12:00am on the day of the event start?
I propose removing Date from all of these, so Event Start, Event End, Registration Start, Registration End.
[Pull request.](https://github.com/civicrm/civicrm-core/pull/20070)5.38.0https://lab.civicrm.org/dev/core/-/issues/2558DB crash when copying event scheduled reminders2021-08-18T01:52:59ZufundoDB crash when copying event scheduled remindersOverview
----------------------------------------
I am experiencing a crash when creating a new event from a template that has scheduled reminders, or trying to copy an event which has scheduled reminders.
The DB error suggests it is t...Overview
----------------------------------------
I am experiencing a crash when creating a new event from a template that has scheduled reminders, or trying to copy an event which has scheduled reminders.
The DB error suggests it is trying to put 0s in the effective_start_date / effective_end_date columns when creating the new scheduled reminders, but this is not allowed.
After the crash, the new event has been created but doesn't have the scheduled reminders it should.
Reproduction steps
----------------------------------------
1. **Events -> New Event**.
1. Choose a template with scheduled reminders
1. Click Continue
1. Fatal db error page :(
OR
1. **Events -> Manage Events**
1. Pick an event with scheduled reminders
1. **More -> Copy**
1. Fatal db error page :(
Current behaviour
----------------------------------------
Error from logs is:
```
.../sites/all/modules/civicrm/vendor/pear/db/DB.php(997): PEAR_Error->__construct("DB Error: unknown error", -1, 16, (Array:2), "INSERT INTO `civicrm_action_schedule` (`name` , `title` , `recipient` , `enti...")
#3 .../sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(575): DB_Error->__construct(-1, 16, (Array:2), "INSERT INTO `civicrm_action_schedule` (`name` , `title` , `recipient` , `enti...")
#4 .../sites/all/modules/civicrm/vendor/pear/pear-core-minimal/src/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -1, 16, (Array:2), "INSERT INTO `civicrm_action_schedule` (`name` , `title` , `recipient` , `enti...", "DB_Error", TRUE)
#5 .../sites/all/modules/civicrm/vendor/pear/db/DB/common.php(1928): PEAR->__call("raiseError", (Array:7))
#6 .../sites/all/modules/civicrm/vendor/pear/db/DB/mysqli.php(936): DB_common->raiseError(-1, NULL, NULL, "INSERT INTO `civicrm_action_schedule` (`name` , `title` , `recipient` , `enti...", "1292 ** Incorrect datetime value: '0' for column 'effective_start_date' at row 1")
```
After the crash, new/copied event is created but without scheduled reminders.
Expected behaviour
----------------------------------------
No error and new/copied event created with copies of scheduled reminders
Environment information
----------------------------------------
* __CiviCRM:__ 5.35
* __PHP:__ 7.3.17
* __CMS:__ Drupal 7.8
* __Database:__ MySQL 5.7.30
Comments
----------------------------------------
I see effective_start_date and effective_end_date columns were added in 5.34 and I wonder if something around the database schema constraints/defaults wasn't set correctly in the/my upgrade?5.37.0https://lab.civicrm.org/dev/core/-/issues/4100Add setting to disable Smarty in Scheduled reminders2023-04-11T12:40:41ZMichael McAndrewAdd setting to disable Smarty in Scheduled remindersUntil now, Smarty has been turned on in scheduled reminders.
This can cause problems when inline CSS is present in the scheduled reminder (e.g. when the html for the reminder was generated via Mosaico using the https://civicrm.org/exten...Until now, Smarty has been turned on in scheduled reminders.
This can cause problems when inline CSS is present in the scheduled reminder (e.g. when the html for the reminder was generated via Mosaico using the https://civicrm.org/extensions/mosaico-message-templates extension). It causes a fatal error when sending the messages which may not be detected and may cause other scheduled jobs to fail.
We could fix this by turning it off but some sites may want to preserve the current behaviour (those who actually use Smarty in their scheduled reminders - we don't now how many of these exist but we presume that they are in the minority - see https://github.com/civicrm/civicrm-core/pull/15436#issuecomment-541923948 for a discussion of why Smarty was enabled originally).
So we:
1. add a new setting `scheduled_reminder_smarty` which by default is null, i.e. we disable this feature for new sites.
2. enable this feature during the upgrade to preserve the existing behaviour
3. let people know they we might want to turn it off in a post upgrade message
We should also consider mentioning this in the https://civicrm.org/extensions/mosaico-message-templates documentation.
See https://github.com/civicrm/civicrm-core/pull/15436 and https://lab.civicrm.org/dev/core/-/issues/58 for relevant background.5.60.0https://lab.civicrm.org/dev/core/-/issues/4377Don't allow scheduled reminders for events to also include groups2023-09-02T05:11:52ZlarsssandergreenDon't allow scheduled reminders for events to also include groupsEdit: See discussion below, this doesn't actually work anyways.
If a user is able to edit events and has access to a particular group, they can add that group to a scheduled reminder for an event with Also include. It doesn't seem like ...Edit: See discussion below, this doesn't actually work anyways.
If a user is able to edit events and has access to a particular group, they can add that group to a scheduled reminder for an event with Also include. It doesn't seem like a good idea to let users scheduled a reminder to potentially a very large number of contacts via an event scheduled reminder, which is intended to email participants for an event.
I can see the case for also including manually selected contacts, but also including groups seems dangerous and an invitation for mistakes. If a user needs to send a scheduled reminder to a group, they would probably be better off using a mailing or a separate scheduled reminder.
Proposal: Disable the Also include > Select Group option in scheduled reminders for events.https://lab.civicrm.org/dev/core/-/issues/4732Scheduled Reminder select2 fields to save/view correctly2023-10-27T00:41:38Zmagnolia61Scheduled Reminder select2 fields to save/view correctlyI am testing 5.68 (master) and run into a problem with Event Type based scheduled reminders.
I think since the Event Type and Registration status have been changed to select2 values are saved but when I re-edit the reminder the field sh...I am testing 5.68 (master) and run into a problem with Event Type based scheduled reminders.
I think since the Event Type and Registration status have been changed to select2 values are saved but when I re-edit the reminder the field show empty.
![image](/uploads/1b0c39ee96ae06c36c0b8dcf2adc1552/image.png)
This is what is recorded in the database:
![image](/uploads/b9f77048338bd4347da0a6cc96cc94e1/image.png)
When I select a single value the behavior of the participant status is different than for the event types. A single value for the participant status gets saved and shown on re-edit.
![image](/uploads/d0659ed253a2ee37a07f21be2f0d70a8/image.png)
BTW. I confirmed this bug on https://dmaster.demo.civicrm.org/
![image](/uploads/b078da97fc6d141a3a5d7d54cc6c1ec0/image.png)
![image](/uploads/c256cd3bdef9f8980be7ab38fdaeb8ed/image.png)