CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2018-10-22T19:47:00Zhttps://lab.civicrm.org/dev/core/-/issues/455Contact Reports: Constituent Summary: fatal error when selecting the column "...2018-10-22T19:47:00ZPradeep Nayakpradpnayak@gmail.comContact Reports: Constituent Summary: fatal error when selecting the column "Location Type"Error: Call to undefined method CRM_Report_Form_Contact_Summary::getLocationTypeOptions() in CRM_Report_Form->alterLocationTypeID() (line 2452 of /Users/pradeep/Sites/civicrm/sites/all/modules/civicrm/CRM/Report/Form.php).
PR: https://...Error: Call to undefined method CRM_Report_Form_Contact_Summary::getLocationTypeOptions() in CRM_Report_Form->alterLocationTypeID() (line 2452 of /Users/pradeep/Sites/civicrm/sites/all/modules/civicrm/CRM/Report/Form.php).
PR: https://github.com/civicrm/civicrm-core/pull/129535.7https://lab.civicrm.org/dev/core/-/issues/428Fatal error in Activity Details report when Sorting uses Section Header2018-11-09T22:11:46ZAllenShawFatal error in Activity Details report when Sorting uses Section Header**Steps to reproduce on dmaster:**
1. Enable debug/backtrace options for better error reporting (this is not required to achieve the relevant fatal error).
1. Open the Activity Details report at http://drupal-demo.amp.l/civicrm/report...**Steps to reproduce on dmaster:**
1. Enable debug/backtrace options for better error reporting (this is not required to achieve the relevant fatal error).
1. Open the Activity Details report at http://drupal-demo.amp.l/civicrm/report/instance/3?reset=1&output=criteria
1. Open the Sort tab and enable the 'Section Header / group by' option for any sort-by column; click *Refresh results* to reload the report with this configuration change.
1. Observe a fatal error page with the following Error Details:
```
Database Error Code: Table 'dmasterciv_jqcej.Array' doesn't exist, 1146
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -18
[message] => DB Error: no such table
[mode] => 16
[debug_info] => SELECT ANY_VALUE(ifnull(civicrm_activity_activity_date_time_date, '')) as civicrm_activity_activity_date_time_date, ANY_VALUE(ifnull(civicrm_contact_contact_assignee, '')) as civicrm_contact_contact_assignee, ANY_VALUE(ifnull(civicrm_contact_contact_target, '')) as civicrm_contact_contact_target, ANY_VALUE(ifnull(civicrm_contact_contact_source_id, '')) as civicrm_contact_contact_source_id, ANY_VALUE(ifnull(civicrm_contact_contact_assignee_id, '')) as civicrm_contact_contact_assignee_id, ANY_VALUE(ifnull(civicrm_contact_contact_target_id, '')) as civicrm_contact_contact_target_id, ANY_VALUE(ifnull(civicrm_activity_id, '')) as civicrm_activity_id, ANY_VALUE(ifnull(civicrm_activity_source_record_id, '')) as civicrm_activity_source_record_id, ANY_VALUE(ifnull(civicrm_activity_activity_type_id, '')) as civicrm_activity_activity_type_id, ANY_VALUE(ifnull(civicrm_activity_activity_subject, '')) as civicrm_activity_activity_subject, ANY_VALUE(ifnull(civicrm_activity_activity_date_time, '')) as civicrm_activity_activity_date_time, ANY_VALUE(ifnull(civicrm_activity_status_id, '')) as civicrm_activity_status_id , count(DISTINCT civicrm_activity_id) as ct from Array group by civicrm_activity_activity_date_time_date [nativecode=1146 ** Table 'dmasterciv_jqcej.Array' doesn't exist]
[type] => DB_Error
[user_info] => SELECT ANY_VALUE(ifnull(civicrm_activity_activity_date_time_date, '')) as civicrm_activity_activity_date_time_date, ANY_VALUE(ifnull(civicrm_contact_contact_assignee, '')) as civicrm_contact_contact_assignee, ANY_VALUE(ifnull(civicrm_contact_contact_target, '')) as civicrm_contact_contact_target, ANY_VALUE(ifnull(civicrm_contact_contact_source_id, '')) as civicrm_contact_contact_source_id, ANY_VALUE(ifnull(civicrm_contact_contact_assignee_id, '')) as civicrm_contact_contact_assignee_id, ANY_VALUE(ifnull(civicrm_contact_contact_target_id, '')) as civicrm_contact_contact_target_id, ANY_VALUE(ifnull(civicrm_activity_id, '')) as civicrm_activity_id, ANY_VALUE(ifnull(civicrm_activity_source_record_id, '')) as civicrm_activity_source_record_id, ANY_VALUE(ifnull(civicrm_activity_activity_type_id, '')) as civicrm_activity_activity_type_id, ANY_VALUE(ifnull(civicrm_activity_activity_subject, '')) as civicrm_activity_activity_subject, ANY_VALUE(ifnull(civicrm_activity_activity_date_time, '')) as civicrm_activity_activity_date_time, ANY_VALUE(ifnull(civicrm_activity_status_id, '')) as civicrm_activity_status_id , count(DISTINCT civicrm_activity_id) as ct from Array group by civicrm_activity_activity_date_time_date [nativecode=1146 ** Table 'dmasterciv_jqcej.Array' doesn't exist]
[to_string] => [db_error: message="DB Error: no such table" code=-18 mode=callback callback=CRM_Core_Error::handle prefix="" info="SELECT ANY_VALUE(ifnull(civicrm_activity_activity_date_time_date, '')) as civicrm_activity_activity_date_time_date, ANY_VALUE(ifnull(civicrm_contact_contact_assignee, '')) as civicrm_contact_contact_assignee, ANY_VALUE(ifnull(civicrm_contact_contact_target, '')) as civicrm_contact_contact_target, ANY_VALUE(ifnull(civicrm_contact_contact_source_id, '')) as civicrm_contact_contact_source_id, ANY_VALUE(ifnull(civicrm_contact_contact_assignee_id, '')) as civicrm_contact_contact_assignee_id, ANY_VALUE(ifnull(civicrm_contact_contact_target_id, '')) as civicrm_contact_contact_target_id, ANY_VALUE(ifnull(civicrm_activity_id, '')) as civicrm_activity_id, ANY_VALUE(ifnull(civicrm_activity_source_record_id, '')) as civicrm_activity_source_record_id, ANY_VALUE(ifnull(civicrm_activity_activity_type_id, '')) as civicrm_activity_activity_type_id, ANY_VALUE(ifnull(civicrm_activity_activity_subject, '')) as civicrm_activity_activity_subject, ANY_VALUE(ifnull(civicrm_activity_activity_date_time, '')) as civicrm_activity_activity_date_time, ANY_VALUE(ifnull(civicrm_activity_status_id, '')) as civicrm_activity_status_id , count(DISTINCT civicrm_activity_id) as ct from Array group by civicrm_activity_activity_date_time_date [nativecode=1146 ** Table 'dmasterciv_jqcej.Array' doesn't exist]"]
)
```
5. Also observe this PHP Notice: `Array to string conversion in CRM_Report_Form_Activity->sectionTotals() (line 1083 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Report/Form/Activity.php).`
**Best guess what's going on:**
The activity Details report assumes the name of a temporary table is stored in `$this->temporaryTables['activity_temp_table']`, but that's really an array. The table name is actually stored in `$this->temporaryTables['activity_temp_table']['name']`.5.7AllenShawAllenShawhttps://lab.civicrm.org/dev/core/-/issues/421Creating a new message template from within CiviMail interface requires both ...2018-11-09T22:11:46ZseamusleeCreating a new message template from within CiviMail interface requires both edit user workflow templates and edit system workflow templates as well as edit message templatesthis is a regression from dev/core#61this is a regression from dev/core#615.7https://lab.civicrm.org/dev/core/-/issues/391Tags do not save with profile forms2018-11-09T22:11:39ZyalhTags do not save with profile formsSteps to reproduce:
Create a tagset
Create or select a profile used for search or view/edit account.
Add "Tag(s)" field to profile
Use profile to edit a contact.
Add tags via the tagset area.
Save profile.
Expec...Steps to reproduce:
Create a tagset
Create or select a profile used for search or view/edit account.
Add "Tag(s)" field to profile
Use profile to edit a contact.
Add tags via the tagset area.
Save profile.
Expected result:
Tags added via tagset field now present on contact.
Actual result:
Tags added via tagset field appear to be ignored.
Extra notes:
Tags successfully added via other means are not displayed in profile form either.
AJAX functions relating to adding tags to the tagset succeed - a child tag is created and can be referenced later.
There was that issue in previous version: https://issues.civicrm.org/jira/browse/CRM-12739
Issue seen in 5.4.15.5.1https://lab.civicrm.org/dev/core/-/issues/379View Activity: extraneous newlines by nl2br on HTML content2018-09-14T04:15:46ZbgmView Activity: extraneous newlines by nl2br on HTML contentThis a regression that was caused a while back by #2 (for I take responsibility, since I mentored/reviewed). We added a nl2br that was a bit too bread in scope, but should have only affected Inbound HTML activities.
How to reproduce on ...This a regression that was caused a while back by #2 (for I take responsibility, since I mentored/reviewed). We added a nl2br that was a bit too bread in scope, but should have only affected Inbound HTML activities.
How to reproduce on http://dcase.demo.civicrm.org :
* Go to a contact record
* Create an activity
* In the details field, add 3 separate lines (by hitting 'enter' once, to create a new paragraph).
![44817615-028c1d00-abb4-11e8-9eba-07b9eb96c029](/uploads/ccb4d0f8a636c37869d0d93455629967/44817615-028c1d00-abb4-11e8-9eba-07b9eb96c029.png)
In the above, you can see that "Line 1" and "Line 2" have a lot of space between them. Inspecting the HTML, it shows that some extra 'br' tags were added between the paragraphs.
If we edit the activity again, the HTML looks OK:
![44817687-3109f800-abb4-11e8-88a4-dccb3b1b957e](/uploads/f69ce244868ea5f50384aa2861f75a7b/44817687-3109f800-abb4-11e8-88a4-dccb3b1b957e.png)
(the newlines in the above screenshot are what made me assume this is a nl2br bug)
PS: this issue was initially reported here: https://github.com/civicrm/org.civicrm.civicase/issues/116 -- but it is not specific to civicase v5.
cc @Detlev5.7bgmbgmhttps://lab.civicrm.org/dev/core/-/issues/377{Membership.Fee} appears on Membership Renewal Reminder emails with 9 decimal...2019-08-15T20:09:19Zpaulorokonui{Membership.Fee} appears on Membership Renewal Reminder emails with 9 decimal placesSimilar to the previously reported issue.....
https://github.com/civicrm/civicrm-core/pull/12186
Screenshots and comments can be found on above thread
civiCRM 5.4.0 on Drupal 7Similar to the previously reported issue.....
https://github.com/civicrm/civicrm-core/pull/12186
Screenshots and comments can be found on above thread
civiCRM 5.4.0 on Drupal 75.18.0https://lab.civicrm.org/dev/core/-/issues/367Fatal error / SQL timeout in A-Z pager for advanced search by relationship wi...2018-08-29T14:26:22ZAllenShawFatal error / SQL timeout in A-Z pager for advanced search by relationship with target group for reciprocal relationship typesPull request: https://github.com/civicrm/civicrm-core/pull/12740
Similar issue but not directly related: https://issues.civicrm.org/jira/browse/CRM-21811
On many sites, this is not an issue, but the more "spouse" relationships a site h...Pull request: https://github.com/civicrm/civicrm-core/pull/12740
Similar issue but not directly related: https://issues.civicrm.org/jira/browse/CRM-21811
On many sites, this is not an issue, but the more "spouse" relationships a site has, the more likely it happens (and not just spouse; this applies for "partner of" and any other reciprocally named relationship type).
**Steps to reproduce:**
1. Start with a site having:
1. Several thousand active relationships of a reciprocal type (where the name for both related positions is the same – e.g., "spouse of" <=> "spouse of"; "sibling of" <=> "sibling of"; "partner of" <=> "partner of"). This recipe uses "Spouse of".
1. At least one group (smart group or static group).
1. Perform an Advanced Search with these criteria:
1. Relationships > Relationship Type: "Spouse of"
1. Relationships > Target Contact(s) in Group: [any one or more groups]
1. Submit the search form and observe a very long page load; depending on the number of relationships, server configuration, and server resources, this search may end in a WSOD, or take dozens of minutes to complete.
**Analysis:**
* When this actually times out, you get a fatal error from MySQL: "Query execution was interrupted (max_statement_time exceeded)"
* Backtrace indicates that the long-running query is the one used to generate the A-Z pager controls in search results; this query includes as join to a temporary table which is created without indices.
**Proposed solution:**
Add indices and column definitions to the temporary table, so that the join can use the indices and run in a timely manner.5.6https://lab.civicrm.org/dev/core/-/issues/365Unwanted mail blast sent by Scheduled Reminders2021-06-10T07:04:39Zmagnolia61Unwanted mail blast sent by Scheduled Reminders**BUG 1:**<br>
I enabled a scheduled reminder which was configured to sent 12 week before the start date of an event.
The start date was a month ago on july 21st.
* Expected behavior: no mail is being sent.
* Actual behaviour: 500 famil...**BUG 1:**<br>
I enabled a scheduled reminder which was configured to sent 12 week before the start date of an event.
The start date was a month ago on july 21st.
* Expected behavior: no mail is being sent.
* Actual behaviour: 500 families got an email with the last details on the event (that already happened).
Over the last few years we have had more incidents like these and it really hurts our reputation, and within our organization it also hurts the reputation of CiviCRM.
The scheduled reminders should be way more clear in configuration and unintentional mail blast should really be prevented by good tests and more solid code.
For this particular issue I would suggest to NOT send a reminder that is configured BEFORE an event, AFTER the event. This could be configured in Civi/ActionSchedule/RecipientBuilder.php although I lack the skills to figure out how.
**BUG 2**<br>
Also what happened is that the reminder was configured for specific participant statuses and it ignored that and sent it anyway to participants with any status. Should be solved but also a test should be introduced for this.
**BUG 3**<br>
The limit to group function seems (sometimes) to be ignored when sending to participants (selected by event type). Should be solved but also a test should be introduced for this.
**CONCLUSION**<BR>
I will further test on clean install, but to me this seems to be critical bugs as they
1) have a reputation impact<br>
2) might impact spam ratings<br>
3) cause a lot of work to follow up (send rectifications, responding to responses by mail)...
....5.39.0https://lab.civicrm.org/dev/core/-/issues/353As of 5.4.0, Activity Search gives an empty result set2018-09-03T01:56:12ZPradeep Nayakpradpnayak@gmail.comAs of 5.4.0, Activity Search gives an empty result setFrom SE: https://civicrm.stackexchange.com/questions/26208/as-of-5-4-0-activity-search-gives-an-empty-result-set-confirmation-anyone
Probably this might have caused regression https://github.com/civicrm/civicrm-core/commit/fd95406da80
...From SE: https://civicrm.stackexchange.com/questions/26208/as-of-5-4-0-activity-search-gives-an-empty-result-set-confirmation-anyone
Probably this might have caused regression https://github.com/civicrm/civicrm-core/commit/fd95406da80
PR: https://github.com/civicrm/civicrm-core/pull/127135.5.0https://lab.civicrm.org/dev/core/-/issues/351ERROR: LoadForm Pop-up w/out Params in URL2018-08-28T21:41:11Zlee.goodingERROR: LoadForm Pop-up w/out Params in URLWhen the loadForm function is used to open a form in a pop-up it will throw an error if NO parameters are included in the URL. If I include a dummy parameter (such as dummy=1) then it will not give me the error.
The function should not...When the loadForm function is used to open a form in a pop-up it will throw an error if NO parameters are included in the URL. If I include a dummy parameter (such as dummy=1) then it will not give me the error.
The function should not require parameters in the URL.
Here is my full error:
`Uncaught TypeError: Cannot read property 'split' of undefined at $.(anonymous function).(anonymous function).isOriginalUrl (http://dev.civicrmdev/sites/all/modules/civicrm/js/crm.ajax.js?pd7a7l:167:34) at $.(anonymous function).(anonymous function).isOriginalUrl (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery-ui/jquery-ui.js?pd7a7l:144:25) at HTMLDivElement.<anonymous> (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery-ui/jquery-ui.js?pd7a7l:256:40) at Function.each (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:370:19) at jQuery.fn.init.each (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:137:17) at jQuery.fn.init.$.fn.(anonymous function) [as crmSnippet] (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery-ui/jquery-ui.js?pd7a7l:236:10) at HTMLDivElement.<anonymous> (http://dev.civicrmdev/sites/all/modules/civicrm/js/crm.ajax.js?pd7a7l:441:34) at HTMLDivElement.dispatch (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:5226:27) at HTMLDivElement.elemData.handle (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:4878:28) at Object.trigger (http://dev.civicrmdev/sites/all/modules/civicrm/bower_components/jquery/dist/jquery.js?pd7a7l:5130:12) isOriginalUrl @ crm.ajax.js?pd7a7l:167 (anonymous) @ jquery-ui.js?pd7a7l:144 (anonymous) @ jquery-ui.js?pd7a7l:256 each @ jquery.js?pd7a7l:370 each @ jquery.js?pd7a7l:137 $.fn.(anonymous function) @ jquery-ui.js?pd7a7l:236 (anonymous) @ crm.ajax.js?pd7a7l:441 dispatch @ jquery.js?pd7a7l:5226 elemData.handle @ jquery.js?pd7a7l:4878 trigger @ jquery.js?pd7a7l:5130 (anonymous) @ jquery.js?pd7a7l:5860 each @ jquery.js?pd7a7l:370 each @ jquery.js?pd7a7l:137 trigger @ jquery.js?pd7a7l:5859 (anonymous) @ crm.ajax.js?pd7a7l:262 fire @ jquery.js?pd7a7l:3232 fireWith @ jquery.js?pd7a7l:3362 done @ jquery.js?pd7a7l:9840 callback @ jquery.js?pd7a7l:10311 XMLHttpRequest.send (async) send @ jquery.js?pd7a7l:10254 ajax @ jquery.js?pd7a7l:9738 jQuery.(anonymous function) @ jquery.js?pd7a7l:9890 getJSON @ jquery.js?pd7a7l:9871 refresh @ crm.ajax.js?pd7a7l:242 (anonymous) @ jquery-ui.js?pd7a7l:144 (anonymous) @ jquery-ui.js?pd7a7l:256 each @ jquery.js?pd7a7l:370 each @ jquery.js?pd7a7l:137 $.fn.(anonymous function) @ jquery-ui.js?pd7a7l:236 CRM.loadPage @ crm.ajax.js?pd7a7l:330 CRM.loadForm @ crm.ajax.js?pd7a7l:355 (anonymous) @ sgt_sgDcGroupManage.js?r=RMsXR:66 dispatch @ jquery.js?pd7a7l:5226 elemData.handle @ jquery.js?pd7a7l:4878`5.6https://lab.civicrm.org/dev/core/-/issues/348Custom Participant tokens not working in scheduled reminders2021-10-02T05:27:54Zmagnolia61Custom Participant tokens not working in scheduled remindersCustom Participant tokens do not work in scheduled reminders.<BR>
I believe the underlying code exists in CiviCRM but it is not possible to use participant tokens.
Work has been done to get these working in pdf creation though: https://...Custom Participant tokens do not work in scheduled reminders.<BR>
I believe the underlying code exists in CiviCRM but it is not possible to use participant tokens.
Work has been done to get these working in pdf creation though: https://issues.civicrm.org/jira/browse/CRM-16734
20200902 Coming back at this issue. I tested again and these are the results using CiviCRM 5.28.4<br>
Situation is an event registration and scheduled reminders being send based on that.
| Type of token | example | result |
| ------ | ------ | ------ |
| Only core event tokens | event.title | get correctly replaced |
| Custom event tokens | event.custom_123| Expected one Event but found 0 |
| Only core participant tokens | participant.role | No error, but do not get replaced |
| Custom participant tokens | participant.custom_123 | No error, but do not get replaced |5.43.0justinfreeman (Agileware)justinfreeman (Agileware)https://lab.civicrm.org/dev/core/-/issues/337QuickForm Error on Contact Search Form when using select custom field of type...2021-01-06T22:42:24ZPradeep Nayakpradpnayak@gmail.comQuickForm Error on Contact Search Form when using select custom field of type IntegerTo Replicate:
Create a 'Select' custom field of type Integer or Number with 'Is this Field Searchable?' checked.
The Advance search form throws fatal error
```
Aug 17 10:16:57 [info] $Fatal Error Details = Array
(
[callback] => Ar...To Replicate:
Create a 'Select' custom field of type Integer or Number with 'Is this Field Searchable?' checked.
The Advance search form throws fatal error
```
Aug 17 10:16:57 [info] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -3
[message] => QuickForm Error: nonexistent html element
[mode] => 16
[debug_info] => Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()
[type] => HTML_QuickForm_Error
[user_info] => Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()
[to_string] => [html_quickform_error: message="nonexistent html element" code=-3 mode=callback callback=CRM_Core_Error::handle prefix="QuickForm Error: " info="Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()"]
)
Aug 17 10:16:57 [info] $backTrace = #0 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Error.php(232): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 [internal function](): CRM_Core_Error::handle(Object(HTML_QuickForm_Error))
#2 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(921): call_user_func((Array:2), Object(HTML_QuickForm_Error))
#3 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(2084): PEAR_Error->__construct("nonexistent html element", -3, 16, (Array:2), "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()")
#4 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(575): HTML_QuickForm_Error->__construct(-3, 16, (Array:2), "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()")
#5 [internal function](): PEAR::_raiseError(NULL, NULL, -3, NULL, 512, "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()", "HTML_QuickForm_Error", TRUE)
#6 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(237): call_user_func_array((Array:2), (Array:8))
#7 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(1076): PEAR::__callStatic("raiseError", (Array:7))
#8 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(1076): PEAR::raiseError(NULL, -3, NULL, 512, "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()", "HTML_QuickForm_Error", TRUE)
#9 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php(1103): HTML_QuickForm->addRule("custom_8_from", "number-select From must be a number (with or without decimal point).", "numeric")
#10 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Contact/Form/Search/Criteria.php(567): CRM_Core_BAO_CustomField::addQuickFormElement(Object(CRM_Contact_Form_Search_Advanced), "custom_8", "8", FALSE, TRUE)
#11 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Contact/Form/Search/Advanced.php(150): CRM_Contact_Form_Search_Criteria::custom(Object(CRM_Contact_Form_Search_Advanced))
#12 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Form.php(606): CRM_Contact_Form_Search_Advanced->buildQuickForm()
#13 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php(92): CRM_Core_Form->buildForm()
#14 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Contact_Form_Search_Advanced), "display")
#15 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contact_Form_Search_Advanced), "display")
#16 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Controller.php(351): HTML_QuickForm_Page->handle("display")
#17 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(309): CRM_Core_Controller->run((Array:4), (Array:0))
#18 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:13))
#19 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:4))
#20 /var/www/html/civicrm-master/sites/all/modules/civicrm/drupal/civicrm.module(445): CRM_Core_Invoke::invoke((Array:4))
#21 [internal function](): civicrm_invoke("contact", "search", "advanced")
#22 /var/www/html/civicrm-master/includes/menu.inc(527): call_user_func_array("civicrm_invoke", (Array:3))
#23 /var/www/html/civicrm-master/index.php(21): menu_execute_active_handler()
#24 {main}
```
When i checked the field through database i found that this field has 'is_search_range' set to TRUE which should be only incase of text or date field i believe.5.9https://lab.civicrm.org/dev/core/-/issues/334Public contribution form and Checksums: billing information not loaded if usi...2020-09-30T22:47:07ZbgmPublic contribution form and Checksums: billing information not loaded if using multiple processorsHow to reproduce:
* Create a Contribution Page
* Associate multiple payment processors
* Create a contact
* Fill in a billing address for the contact
* Generate a contribution page link that includes the checksum (cs) and cid.
What hap...How to reproduce:
* Create a Contribution Page
* Associate multiple payment processors
* Create a contact
* Fill in a billing address for the contact
* Generate a contribution page link that includes the checksum (cs) and cid.
What happens:
* The payment block does not pre-populate the Billing Address
* Note that this only happens when there are multiple processors, because of the ajax request that loads the payment block. This request does not happen when there is only one PP.5.6https://lab.civicrm.org/dev/core/-/issues/326Fatal error 'DB Error: no such field' on Contribution detail report when sect...2018-11-09T22:11:38ZPradeep Nayakpradpnayak@gmail.comFatal error 'DB Error: no such field' on Contribution detail report when section header enabledError code : Database Error Code: Unknown column 'civicrm_contribution_total_amount' in 'field list', 1054
![Peek_2018-08-14_16-19](/uploads/519bfa9483886f0ef2df276e76d1eb80/Peek_2018-08-14_16-19.gif)
Issue filed on stackexchange : ht...Error code : Database Error Code: Unknown column 'civicrm_contribution_total_amount' in 'field list', 1054
![Peek_2018-08-14_16-19](/uploads/519bfa9483886f0ef2df276e76d1eb80/Peek_2018-08-14_16-19.gif)
Issue filed on stackexchange : https://civicrm.stackexchange.com/questions/26124/db-error-missing-field-in-contribution-reports-after-upgrade-to-5-4-0-drupal/261265.5.0https://lab.civicrm.org/dev/core/-/issues/311Upgrading multilingual site causes DB Error2018-10-22T19:13:55ZDon WijesooriyaUpgrading multilingual site causes DB ErrorUpgrading from CiviCRM 4.4.7 to 5.4.0 (Drupal), cause a DB error. Upgrade process works fine but when loading any civi page, JavaScript error is displayed on the language file (backtrace displayed after enabling).
![javascript](/upload...Upgrading from CiviCRM 4.4.7 to 5.4.0 (Drupal), cause a DB error. Upgrade process works fine but when loading any civi page, JavaScript error is displayed on the language file (backtrace displayed after enabling).
![javascript](/uploads/cc865f9f1870d12a4b79309623de8147/javascript.PNG)
Checking the error log, few fields relating to uf_group are not getting created during the upgrade.
![errorlog](/uploads/8424555a1c8f657bbab2d6f05d5f4c08/errorlog.PNG)
Further investigation showed that in CRM/Core/I18n, there have been schema changes between the latest SchemaStructure.php and SchemaStructure_4_7_alpha1.php thus we had to copy and rename the file as SchemaStructure_5_4_alpha1.php as mentioned [here.](https://docs.civicrm.org/dev/en/latest/translation/database/#localised-fields-schema-changes)
![schemastructure](/uploads/c05dd2b1213cad872366dc0b5f9a43be/schemastructure.PNG)5.6https://lab.civicrm.org/dev/core/-/issues/277Recurring contribution tab shouldn't count test transactions2018-07-31T22:12:11ZPradeep Nayakpradpnayak@gmail.comRecurring contribution tab shouldn't count test transactions![Screenshot_from_2018-07-24_13-27-48](/uploads/4ec1bca56c36f0c71cf2b7694662bde6/Screenshot_from_2018-07-24_13-27-48.png)
PR at https://github.com/civicrm/civicrm-core/pull/12553![Screenshot_from_2018-07-24_13-27-48](/uploads/4ec1bca56c36f0c71cf2b7694662bde6/Screenshot_from_2018-07-24_13-27-48.png)
PR at https://github.com/civicrm/civicrm-core/pull/125535.5.0https://lab.civicrm.org/dev/core/-/issues/267Proposal - remove net_amount from contribution edit form - at least in edit m...2018-11-16T06:59:41ZeileenProposal - remove net_amount from contribution edit form - at least in edit mode.When people edit the total_amount on a contribution they have to edit the net_amount to match - why? We can calculate it.
**What happens now?**
For new contributions with no fees it is enough for the user to enter total amount. Howeve...When people edit the total_amount on a contribution they have to edit the net_amount to match - why? We can calculate it.
**What happens now?**
For new contributions with no fees it is enough for the user to enter total amount. However, if there is a fee they need to enter the fee AND calculate net_amount and enter them. If they edit the amount they need to update the net amount to be the same as the total amount less the fee amount.
The current behaviour dates back to svn days - however since 2015 the BAO has handled the possibility
of it not being set.
**What issues are there with this**
1. It causes pain for users
1. In addition we have had code issues with the comparison around [currency & float comparison issues](https://github.com/civicrm/civicrm-core/pull/11485) and [sales tax](https://lab.civicrm.org/dev/core/issues/260). In both cases the user cannot enter the correct data.
1. It undermines our unit testing - in Mar 2017 [the unit tests were edited](https://github.com/civicrm/civicrm-core/pull/9948/files#diff-40e2e0f106ba620465acf3a9a81f2498L1535) to remove net_amount from the form submission values in our unit tests. New tests written since then have been based on these net_amountless tests.
**[Proposed change Remove the field altogether from the form]
(https://github.com/eileenmcnaughton/civicrm-core/commit/0bee3ce6fa18fa24d75c7bb9e86618ff0ac1f025)**
**Risks**
I would hope some people would commit to testing the rc - but as mentioned above our tests already expect it not to be set so we are already testing the proposed scenario.
there is a risk that some people really like the fact that when the edit the total_amount and not the fee_amount they get a validation error - IF that seems to be a real issue - not just me flailing around for reasons - then we could either move the fee_amount field or have some UI sugar mentioning the fee_amount next to total_amount.
Here is the BAO function that calculates it.
```
/**
* Calculate net_amount & fee_amount if they are not set.
*
* Net amount should be total - fee.
* This should only be called for new contributions.
*
* @param array $params
* Params for a new contribution before they are saved.
* @param int|null $contributionID
* Contribution ID if we are dealing with an update.
*
* @throws \CiviCRM_API3_Exception
*/
public static function calculateMissingAmountParams(&$params, $contributionID) {
if (!$contributionID && !isset($params['fee_amount'])) {
if (isset($params['total_amount']) && isset($params['net_amount'])) {
$params['fee_amount'] = $params['total_amount'] - $params['net_amount'];
}
else {
$params['fee_amount'] = 0;
}
}
if (!isset($params['net_amount'])) {
if (!$contributionID) {
$params['net_amount'] = $params['total_amount'] - $params['fee_amount'];
}
else {
if (isset($params['fee_amount']) || isset($params['total_amount'])) {
// We have an existing contribution and fee_amount or total_amount has been passed in but not net_amount.
// net_amount may need adjusting.
$contribution = civicrm_api3('Contribution', 'getsingle', array(
'id' => $contributionID,
'return' => array('total_amount', 'net_amount'),
));
$totalAmount = isset($params['total_amount']) ? $params['total_amount'] : CRM_Utils_Array::value('total_amount', $contribution);
$feeAmount = isset($params['fee_amount']) ? $params['fee_amount'] : CRM_Utils_Array::value('fee_amount', $contribution);
$params['net_amount'] = $totalAmount - $feeAmount;
}
}
}
}
```5.6https://lab.civicrm.org/dev/core/-/issues/264Fatal Error on editting Financial Transaction2019-03-15T20:08:39ZtommyboboFatal Error on editting Financial TransactionIn 5.3.0 tested on Dev site and civicrmfr.org demo
1. Create a completed contribution.
2. Edit contribution by increasing contribution amount and net amount.
This will create a new financial transaction with NO Payment Instrument.
3...In 5.3.0 tested on Dev site and civicrmfr.org demo
1. Create a completed contribution.
2. Edit contribution by increasing contribution amount and net amount.
This will create a new financial transaction with NO Payment Instrument.
3. Edit new Financial Transaction to add Payment Instrument. Click Update - Get Spinning Logo Error
ConfigAndLog Records this error.
```
$Fatal Error Details = array(3) {
["message"]=>
string(65) "Mandatory key(s) missing from params array: payment_instrument_id"
["code"]=>
NULL
["exception"]=>
object(CiviCRM_API3_Exception)#323 (8) {
["extraParams":"CiviCRM_API3_Exception":private]=>
array(6) {
["fields"]=>
array(1) {
[0]=>
string(21) "payment_instrument_id"
}
["error_code"]=>
string(17) "mandatory_missing"
["entity"]=>
string(13) "FinancialTrxn"
["action"]=>
string(6) "create"
["is_error"]=>
int(1)
["error_message"]=>
string(65) "Mandatory key(s) missing from params array: payment_instrument_id"
}
["message":protected]=>
string(65) "Mandatory key(s) missing from params array: payment_instrument_id"
["string":"Exception":private]=>
string(0) ""
["code":protected]=>
int(0)
["file":protected]=>
string(65) "/server/public_html/sites/all/modules/civicrm/api/api.php"
["line":protected]=>
int(45)
["trace":"Exception":private]=>
array(15) {
[0]=>
array(4) {
["file"]=>
string(88) "/server/public_html/sites/all/modules/civicrm/CRM/Financial/Form/PaymentEdit.php"
["line"]=>
int(207)
["function"]=>
string(12) "civicrm_api3"
["args"]=>
array(3) {
[0]=>
string(13) "FinancialTrxn"
[1]=>
string(6) "create"
[2]=>
array(9) {
["to_financial_account_id"]=>
string(2) "23"
["trxn_date"]=>
string(19) "2018-07-16 17:23:00"
["total_amount"]=>
float(-10)
["fee_amount"]=>
float(0)
["net_amount"]=>
float(-10)
["currency"]=>
string(3) "USD"
["is_payment"]=>
string(1) "1"
["status_id"]=>
string(1) "1"
["contribution_id"]=>
string(5) "30997"
}
}
}
[1]=>
array(6) {
["file"]=>
string(88) "/server/public_html/sites/all/modules/civicrm/CRM/Financial/Form/PaymentEdit.php"
["line"]=>
int(175)
["function"]=>
string(6) "submit"
["class"]=>
string(30) "CRM_Financial_Form_PaymentEdit"
["type"]=>
string(2) "->"
["args"]=>
array(1) {
[0]=>
array(4) {
["id"]=>
string(5) "39513"
["payment_instrument_id"]=>
string(1) "3"
["trxn_id"]=>
string(0) ""
["trxn_date"]=>
string(19) "2018-07-16 17:23:00"
}
}
}
```5.3.1https://lab.civicrm.org/dev/core/-/issues/263Release candidate regression: Can't create contribution pages.2018-07-18T22:42:07ZJonGoldRelease candidate regression: Can't create contribution pages.I've replicated this locally on the rc, the master branch and on the demo site.
* Create a new contribution page, filling in only the two required fields.
* Press "Submit".
Get this:
```
backTrace
#0 /home/jon/local/civicrm-buildkit/b...I've replicated this locally on the rc, the master branch and on the demo site.
* Create a new contribution page, filling in only the two required fields.
* Press "Submit".
Get this:
```
backTrace
#0 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/Error.php(190): CRM_Core_Error::backtrace()
#1 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/PEAR.php(921): CRM_Core_Error::handle(Object(DB_Error))
#2 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/DB.php(985): PEAR_Error->__construct("DB Error: unknown error", -1, 16, (Array:2), "INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id...")
#3 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/PEAR.php(575): DB_Error->__construct(-1, 16, (Array:2), "INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id...")
#4 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -1, 16, (Array:2), "INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id...", "DB_Error", TRUE)
#5 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/DB/common.php(1907): PEAR->__call("raiseError", (Array:7))
#6 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/DB/mysqli.php(933): DB_common->raiseError(-1, NULL, NULL, "INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id...", "1292 ** Incorrect datetime value: '7' for column 'start_date' at row 1")
#7 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/DB/mysqli.php(403): DB_mysqli->mysqliRaiseError()
#8 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/DB/common.php(1216): DB_mysqli->simpleQuery("INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id...")
#9 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/DB/DataObject.php(2443): DB_common->query("INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id...")
#10 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/DB/DataObject.php(1068): DB_DataObject->_query("INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id...")
#11 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/DAO.php(571): DB_DataObject->insert()
#12 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Contribute/BAO/ContributionPage.php(59): CRM_Core_DAO->save()
#13 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Contribute/Form/ContributionPage/Settings.php(344): CRM_Contribute_BAO_ContributionPage::create((Array:25))
#14 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/Form.php(489): CRM_Contribute_Form_ContributionPage_Settings->postProcess()
#15 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/StateMachine.php(160): CRM_Core_Form->mainProcess()
#16 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Next.php(61): CRM_Core_StateMachine->perform(Object(CRM_Contribute_Form_ContributionPage_Settings), "next", "Next")
#17 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Next->perform(Object(CRM_Contribute_Form_ContributionPage_Settings), "next")
#18 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contribute_Form_ContributionPage_Settings), "next")
#19 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/Controller.php(351): HTML_QuickForm_Page->handle("next")
#20 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/Invoke.php(309): CRM_Core_Controller->run((Array:4), NULL)
#21 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:14))
#22 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:4))
#23 /home/jon/local/civicrm-buildkit/build/rc/sites/all/modules/civicrm/drupal/civicrm.module(445): CRM_Core_Invoke::invoke((Array:4))
#24 /home/jon/local/civicrm-buildkit/build/rc/includes/menu.inc(527): civicrm_invoke("admin", "contribute", "add")
#25 /home/jon/local/civicrm-buildkit/build/rc/index.php(21): menu_execute_active_handler()
#26 {main}
Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred.
DB Error: unknown error
Error Details
Database Error Code: Incorrect datetime value: '7' for column 'start_date' at row 1, 1292
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] => INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id , is_credit_card_only , is_confirm_enabled , goal_amount , is_active , footer_text , start_date , end_date , created_id , created_date , currency , is_share ) VALUES ('test' , NULL , 3 , 0 , 1 , NULL , 1 , NULL , 7 , NULL , 202 , 20180717100536 , 'USD' , 0 ) [nativecode=1292 ** Incorrect datetime value: '7' for column 'start_date' at row 1]
[type] => DB_Error
[user_info] => INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id , is_credit_card_only , is_confirm_enabled , goal_amount , is_active , footer_text , start_date , end_date , created_id , created_date , currency , is_share ) VALUES ('test' , NULL , 3 , 0 , 1 , NULL , 1 , NULL , 7 , NULL , 202 , 20180717100536 , 'USD' , 0 ) [nativecode=1292 ** Incorrect datetime value: '7' for column 'start_date' at row 1]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::handle prefix="" info="INSERT INTO civicrm_contribution_page (title , intro_text , financial_type_id , is_credit_card_only , is_confirm_enabled , goal_amount , is_active , footer_text , start_date , end_date , created_id , created_date , currency , is_share ) VALUES ('test' , NULL , 3 , 0 , 1 , NULL , 1 , NULL , 7 , NULL , 202 , 20180717100536 , 'USD' , 0 ) [nativecode=1292 ** Incorrect datetime value: '7' for column 'start_date' at row 1]"]
)
```5.4.0https://lab.civicrm.org/dev/core/-/issues/259OptionGroup Admin UI workflow improvements2018-12-18T12:16:03Zmattwiremjw@mjwconsult.co.ukOptionGroup Admin UI workflow improvementsVarious improvements to the "flow" of the option groups admin pages.
Before
----------------------------------------
* No option to edit option group settings (eg. change the label).
* When clicking "Done" editing options, redirect to t...Various improvements to the "flow" of the option groups admin pages.
Before
----------------------------------------
* No option to edit option group settings (eg. change the label).
* When clicking "Done" editing options, redirect to the option groups list instead of the default admin page.
After
----------------------------------------
* Add option to edit option group settings (the code was already in place, but not exposed in UI).
* Display "is_reserved" status on option group settings.
* Don't allow changing data type on reserved option groups.
* On update optiongroup don't touch is_reserved.
![localhost_8000_civicrm_admin_options_action browse reset 1 4](https://user-images.githubusercontent.com/2052161/42726000-43ca3642-8785-11e8-9ea3-d0228ceb558e.png)
![localhost_8000_civicrm_admin_options_action browse reset 1 5](https://user-images.githubusercontent.com/2052161/42726002-48fc8520-8785-11e8-9ebc-9267444e510f.png)
* When clicking "Done" editing options, redirect to the option groups list instead of the default admin page.
![localhost_8000_civicrm_admin_options_action browse reset 1 6](https://user-images.githubusercontent.com/2052161/42726010-6995ac9e-8785-11e8-8823-111f71f52d07.png)
Technical Details
----------------------------------------
UI only changes that enable editing option groups parameters.
Comments
----------------------------------------
If you are working with multiple option groups, the UI has always been a bit difficult to navigate and various functions are not possible via the UI (such as changing the label of an option group).
PR: https://github.com/civicrm/civicrm-core/pull/124735.5.0