GitLab

CRM-20347 Fatal error on delete participant record with related contr…

CRM-19385 revert changes to order by id on prevnext_cache.

After PR #10019 was merged @bhahumanists reported on #9801 that smart group ordering was broken. The
report is lacking detail and I could not replicate it, but am reverting the search changes for safety.

After this revert sites can still experiment with dropping/altering the primary key on
-civicrm_cache
-civicrm_group_contact_cache
-civicrm_acl_cache

But not civicrm_prevnext_cache.

Although I could not replicate the search issue it seems to me that our Ubuntu test suite
is failing where the other one is not on search-related items, suggesting that
for some reason Ubuntu does not default to the natural search order, due to
some config or other difference

CRM-20342: add 'view' Api action

Minor test tidy up.

(this is actually because we need a commit to do a merge to master after the same commit was merged to both).

CRM-20334, some times payment object is not set and is protected vari…

----------------------------------------
* CRM-20334: Fatal Error on Submit Credit Card Form
  https://issues.civicrm.org/jira/browse/CRM-20334

Enotice fix

CRM-20251 Make it easier to overwrite front end form help text regard…

CRM-20294 Update membership dates in profiles to use datepicker

Fix up test to create line_items & memberships accurately

CRM-20302 - Support search by/return tags in case api

CRM-19914 - civicrmHooks.php issues on windows

extract two core API permission functions

Validate integer is performed by the api wrapper.

CRM-20216 - Dedupe rules should be prevented from being saved if Weig…

CRM-19385 - remove dependence on ids in cache tables.

This removes the use of the primary id keys in the cache tables. The upgrade part of this
has gone stale a few times but I feel sure that this part is tested & confirmed
and committing this part will make testing easier

This will enable a bit of discoverability for the entity x action
matrix.

This is pretty much a cut and paste job so should be no functional
change.

Fixes CRM-19308: Disallow false-y values for paths purged during cach…

CRM-20299 - CiviMail UI - Cleanup "Location Type" and "Selection Method"

CRM-19979 - Too big amount saved despite error

CRM-20252 Improve text when processing possibly-delayed-payments

New GenCodeChecksum for auto-generated DAO files

Minor comment fixes & function extraction.

If you select a "Location Type" and then deselect it, the field changes
to "Automatic". This is the default value (which is acceptable), but the UI
flags it as erroneous.

The "Selection Method" also defaults to "Automatic".  These fields are oddly
a bit different (e.g.  "Automatic" translates to `location_type_id==null`
and `email_selection_method=automatic`), so the fields are a little
different, but this revision brings them closer.