GitLab

GitLab issue 652 Copying activity file custom data doesn't copy mime …

(WIP) #670 - Fix Saving of Case Activity tags

Simplify billingblock in Contribution/Form/Main template

C51-384: Added case tokens on Email Activity Modal

REF Remove undefined variable when creating note

Add main nav icon for CiviCRM (Backdrop)

removed unwanted parameter from getLineItems()

(since Backdrop core now has main nav icons)

Deprecate unused function

Fix order api to support a pseudoConstant for financial_type_id

Adds functionality & test to support 'Event Fee' instead of '4' for Order.create financial_type_id.

This improves consistency with Contribution.create api and others

financial#39: Drop checkMD5 support from Authorize.net

5.10 to master

(#660) Address regression whereby Anonymous users can no longer register for an event if they have ACLs to see a contact

Email sent from CiviCRM for a new Case and Activity does not evaluate the $activityTypeName or $manageCaseURL tokens

(NFC) Add unit test of creating notes from the contact.create API

Convert Paypal Standard IPN payment_date to system's time zone

Remove inappropriate exception handling.

Translate untranslated string

REF Remove duplicate call to session singleton

Escape the header title & section title in reports to better support extensions

setLocale: precaution for when setLocale is called on an unilingual site

Add unit test for emailing receipts from additional payment page

This won't actually remove it from installs - we need to address that separately via ensuring people can and do run
the System.updateIndices api call but it removes it from new installs and from
tests, hence the test should pass

Add test to demonstrate fatal error when accessing permitted users that are cached using the acl_cache.

This has arisen during investigation of a possible regression - it turns out that if you give the 'everyone' group
access to a contact using ACLs (or hooks I believe) they get a fatal error on any attempt at event or other registration.

The issue is that when attempting to check for duplicates the call is made using check_permission. This in itself is a possible
regression as the CRM_Dedupe_Finder::dupesByParams function now drops the check_permission key when it is equal to 0 from

https://github.com/civicrm/civicrm-core/commit/4f33e78b901fb7cdb38a3026f88b59a2f9fd2c68

So we have an issue that
1) we are now applying check_permission when doing a dupe_check from front end forms - this probably is resulting in 5.9
sites getting too many duplicates are they would always be null for anon users
2) if we DO do a permissions check when an acl or hook has been used to give anon users permission to access
contacts then they will get a fatal error. This is because it sets contact_id to 0 and attempts to insert it into the
acl_contact_cache.

I think we need to either remove the array_filter line that we think we may not need per code comments
or add specific handling for the check_permission flag

AND drop the foreign key constraint on the civicm_acl_contact_cache table. This means they will
no longer be removed when a contact is deleted but this is a clean up issue rather than one with
functionaly implications & we *should* have some form of cleanup in play on that table. In addition,
removing the constraint will reduce write contention