1. 18 Mar, 2019 1 commit
  2. 15 Mar, 2019 2 commits
  3. 14 Mar, 2019 4 commits
  4. 13 Mar, 2019 3 commits
    • Seamus Lee's avatar
      Merge pull request #13801 from eileenmcnaughton/5.12 · fb617dca
      Seamus Lee authored
      Fix unrelased regression where activity date relative filters are ingnored in the rc
      fb617dca
    • eileen's avatar
      Merge pull request #13808 from totten/5.12-wp-e2e · a78ec513
      eileen authored
      (ops#878) (Fast)ArrayDecorator - Emit expected exception when using WP and strict PSR-16
      a78ec513
    • totten's avatar
      (Fast)ArrayDecorator - Emit expected exception when using WP and strict PSR-16 · 8a8cbada
      totten authored
      Suppose someone calls `ArrayDecorator::get()` or `FastArrayDecorator::get()`
      with an invalid key (e.g.  passing `float` or an `array` instead of a
      `string`).  This patch improves error-reporting for that scenario.
      
      This is primarily about fixing multiple test failures in `E2E_Cache_ArrayDecoratorTest` reported on `wp-demo`. These
      generally look like
      
      ```
      1) E2E_Cache_ArrayDecoratorTest::testGetInvalidKeys with data set #1 (true)
      array_key_exists(): The first argument should be either a string or an integer
      
      /Users/totten/bknix/build/wpmaster/wp-content/plugins/civicrm/civicrm/CRM/Utils/Cache/ArrayDecorator.php:102
      /Users/totten/bknix/build/wpmaster/wp-content/plugins/civicrm/civicrm/packages/Cache/IntegrationTests/LegacySimpleCacheTest.php:409
      /Users/totten/bknix/civicrm-buildkit/extern/phpunit5/phpunit5.phar:598
      ```
      
      Before
      ------
      
      The ArrayDecorator first checks its front cache (`array_key_exists`) to see if the key is defined.  In the `wp-demo`
      environment, this produces a warning and causes the test to fail.
      
      The condition *is* erroneous, but PSR-16 specifies that the error should be reported as exception.
      
      After
      -----
      
      The condition is reported as the expected exception. The test passes on `wp-demo`.
      
      Comment
      -------
      
      This brings the code in `(Fast)ArrayDecorator.php` into alignment with most of the other `CRM/Utils/Cache/*.php`
      drivers; in most drivers, it is typical to validate the key at the start of most functions.
      8a8cbada
  5. 12 Mar, 2019 2 commits
    • eileen's avatar
      Fix relative dates when searching on activity_date_time · 8fc9f99a
      eileen authored
      In testing I found that there is an unreleased regression relating to our date conversion
      on activity_date_time in activity search. This fixes and adds tests. (regression was it
      was being ignored).
      
      Note that the option value is capitalised which makes the capitalisation slightly odd but
      I think accepting that is the least bad option
      8fc9f99a
    • eileen's avatar
      Formatting cleanup · a6b674bb
      eileen authored
      a6b674bb
  6. 07 Mar, 2019 4 commits
  7. 06 Mar, 2019 16 commits
  8. 05 Mar, 2019 8 commits