1. 05 Jun, 2018 4 commits
  2. 27 May, 2018 2 commits
  3. 16 May, 2018 5 commits
  4. 13 May, 2018 1 commit
  5. 12 May, 2018 2 commits
  6. 11 May, 2018 1 commit
  7. 10 May, 2018 4 commits
  8. 08 May, 2018 2 commits
    • Monish Deb's avatar
      Merge pull request #12080 from eileenmcnaughton/fgb · 51275f25
      Monish Deb authored
      Fix (unreleased) regression on report pager
      51275f25
    • eileen's avatar
      Fix (unreleased) regression on report pager · b040d4b6
      eileen authored
      We recently added a patch to disable full group by before some queries that were not
      compliant with that standard. That patch broke the report pager because later code relied on the
      last issued query ALWAYS being the one that determined how many rows are retrived by the main query,
      however, we were doing a query to check sql mode after the main query.
      
      I could make a case for storing sql mode data somewhere sensible at the start of the session.
      However, I think this fix is the right fix for the bug as it calculates the rows retrieved
      / retrievable immediately after the retrieval query, rather than 'at some later date when
      we hope no other queries have run'. If is in the same function as the enableFullGroupBy so
      only reports that ALSO run that will hit the line (ie. not reports that override buildRows)
      b040d4b6
  9. 06 May, 2018 1 commit
  10. 04 May, 2018 2 commits
  11. 02 May, 2018 6 commits
  12. 01 May, 2018 10 commits