1. 12 Jul, 2019 1 commit
  2. 04 Jul, 2019 1 commit
  3. 02 Jul, 2019 1 commit
    • DaveD's avatar
      WIP · c33f1df1
      DaveD authored
  4. 30 Jun, 2019 1 commit
  5. 22 Jun, 2019 1 commit
  6. 13 Jun, 2019 1 commit
  7. 08 Jun, 2019 3 commits
  8. 02 May, 2019 1 commit
  9. 26 Apr, 2019 2 commits
  10. 18 Apr, 2019 1 commit
  11. 07 Apr, 2019 1 commit
  12. 05 Apr, 2019 1 commit
  13. 13 Dec, 2018 1 commit
  14. 04 Dec, 2018 1 commit
  15. 09 Oct, 2018 1 commit
    • Chris Burgess's avatar
      GL-425: Log a message if CiviCRM thinks SSL is not enabled · b12378a7
      Chris Burgess authored
      The enableSSL setting doesn't reliably detect the presence of SSL (especially
      when behind SSL terminating proxies). This log message will allow people
      affected by this behaviour to more readily debug it, because CiviCRM
      will give them a clue to work with.
      See #425
  16. 28 Sep, 2018 1 commit
    • totten's avatar
      Register "short" and "long" cache services · 90cdaa0e
      totten authored
      This is an improvement for developer-experience when working with caches.
      It reduces the amount of boilerplate required for core-code or
      extension-code in a typical caching use-case.
      * To use a short-lived/latency-optimized cache (e.g. Redis or PHP array),
        you can work with the default cache instance (`Civi::cache('default')`.
      * To use a long-lived/durability-optimized cache (e.g. Redis or SQL), there is no
        simple way or code. You must [register a custom cache service](https://docs.civicrm.org/dev/en/latest/framework/cache/#example-named-service).
      * All the above remains true. Additionally, you can request the `short` or `long` cache service.
      * To use a short-lived/latency-optimized cache, you can use `Civi::cache('short')`. (`short` and `default` are synonmyms.)
      * To use a long-lived/durability-optimized cache, you can use use `Civi::cache('long')`.
      * After this is approved, we should update the [dev docs for caching](https://docs.civicrm.org/dev/en/latest/framework/cache/).
      * There's a bike-sheddy argument about the naming. I'd be willing to rename if there was a strong reason, but I don't really think
        there is a strong reason. This naming convention provides a simple dichotomy of `short` vs `long`.
  17. 28 Jul, 2018 1 commit
    • totten's avatar
      Overview · 70423e0d
      totten authored
      `CRM_Utils_System::flushCache()` calls `CRM_Utils_Cache::singleton()->flush()`.
      In `5.3`, this triggered a cascading effect; in development of `5.4.alpha`,
      some of the cascades were overzealous and we revised to get tighter control
      over cascading.
      With an aim to being conservative and reproducing old behavior, I previously
      patched `5.4.alpha` to add several extra flushes and simulate the old cascades.
      However, it wasn't really as conservative as hoped -- because the "old
      behavior" depended on the environment.  This patch brings us closer the "old
      See also: #284
      Before (Behavior in version <=`5.3`)
      On systems with memory-backed caches, `flushCache()` had an aggressive
      cascading side-effect where several named caches (`settings`, etc) were also
      On systems with a default configuration (SQL+ArrayCache), `flushCache()` had a
      very limited cascading effect -- it *only cleared the in-process ArrayCache*.
      The bulk of the cache content was preserved in SQL.
      Before (Behavior in version ~= `5.4.alpha`)
      To simulate the cascading effect, `flushCache()` explicitly flushes a
      half-dozen individual caches.  (These half-dozen are chosen to match the old
      cascade list and exclude some new things which would problematic.)
      On systems with memory-backed caches, this reproduces the aggressive cascading
      On systems with a default configuration (SQL+ArrayCache), this amplifies the
      flushing -- because it also destroys the underlying SQL caches.
      This has the side-effect of significantly degrading performance of the test
      After (Behavior with patch)
      `CRM_Utils_System::flushCache` calls `CRM_Utils_Cache::singleton()->flush()`.
      To simulate the cascading effect, `flushCache()` explicitly flushes a
      half-dozen individual caches...  *but only on memory-backed* systems.
      On systems with memory-backed caches, this reproduces the aggressive cascading
      On systems with a default configuration (SQL+ArrayCache), this is closer to the
      old behavior.  The bulk of the cache remains available in SQL.
      Based on local spot-checking, this restores performance of the test suite.
      Deep down, I don't really believe the cascading effect is a good thing.  At
      some point, I'd rather just remove these bits.  But in absence of a crystal
      ball to predict the side-effects of that, I think it's good to find a better
      approximation of the old behavior.
  18. 19 Jun, 2018 1 commit
    • totten's avatar
      (#174) System::flushCache() - Continue existing behavior aftering fixing prefixes · 5aac553c
      totten authored
      The preceding update to `CRM_Utils_Cache` meant that `CRM_Utils_Cache::singleton()->flush()`
      (aka `Civi::cache()->flush()`) would flush only the *default* cache. This revision
      ensures that a general system-flush still hits the same caches.
      However, we can now define *other* caches which *won't* be hit by system-flush.
  19. 11 May, 2018 1 commit
  20. 03 May, 2018 1 commit
  21. 19 Apr, 2018 1 commit
    • totten's avatar
      (NFC) Update version in header · fee14197
      totten authored
      This is a simple administrative update to the headers. It was generated with the command:
      rgrep '| CiviCRM version 4.7' CRM/ Civi ang api bin extern install/ settings/ templates -l \
        | xargs sed -i'' "s/| CiviCRM version 4.7/| CiviCRM version 5  /g"
      Tthe inclusion of `|` aimed to avoid matching any non-header text (e.g. inline docs that
      mentioned the version incidentally). But then I did a looser search and for just
      rgrep 'CiviCRM version 4.7'
      and manually patched the remainder.
      Note: I'm not really keen on doing this every month, so I relaxed the header
      statement -- instead of `CiviCRM version 5.0`, it's just `CiviCRM version 5`.
  22. 16 Mar, 2018 2 commits
  23. 14 Mar, 2018 1 commit
    • eileen's avatar
      CRM-21659 Add hook to CRM_Utils_System::redirect · f9bdf062
      eileen authored
      fixup CRM-21659 Add hook to CRM_Utils_System::redirect
      This renames the hook function to be stylistically more consistent.  In
      other tests, the function name matches the hook name.
  24. 23 Feb, 2018 1 commit
  25. 21 Feb, 2018 1 commit
  26. 22 Aug, 2017 1 commit
  27. 13 Jun, 2017 1 commit
  28. 21 Apr, 2017 1 commit
  29. 25 Feb, 2017 1 commit
  30. 24 Jan, 2017 1 commit
  31. 11 Jan, 2017 1 commit
  32. 02 Jan, 2017 1 commit
  33. 12 Oct, 2016 1 commit
  34. 12 Aug, 2016 1 commit
  35. 22 Jun, 2016 1 commit
  36. 21 Mar, 2016 1 commit