GitLab

Add unit test for api ContributionRecur.cancel, add support for cancel_reason

(NFC) Update CRM/Member CRM/Note CRM/Logging CRM/Import and CRM/Price…

#855 Fix guzzle noisiness

(NFC) Update CRM/Activity CRM/Admin and CRM/Batch folders to be the f…

(NFC) Update CRM/Member CRM/Note CRM/Logging CRM/Import and CRM/Price folders to be a future coder standard

There is no reason to echo the failure here

(NFC) Update coding style in PCP, Pledge, Profile, Queue, Report folders

(NFC) Update CRM/SMS/ CRM/UF/ CRM/Upgrade/ CRM/Tag/ to be up to speed…

(NFC) Bring CRM/Utils folder up to future coder standards

(NFC) Set _log and _tableName variables to be public

Update Unit test styling to cover the future coder version

(NFC) Fix location of comment to match future coder version

(NFC) Bring up API folder to style of future coder checker

Encourage developers to use .then instead of .done

(NFC) Upgrade Civi Folder to the new coder version

jQuery promises have both methods which (if only passing one argument) are
interchangeable. But native js promises do not have a .done method, so let's
start getting our code more future-proof.

(NFC) Update various files to pass future civicrm/coder ruleset

(NFC) Update various files to pass current phpcs

Method:

* Checkout latest merged branch of civicrm/coder (`8.x-2.x-civi`)
* Run this command to autoclean a batch of 100 files
  `PG=2 SIZE=100 ; find Civi/ CRM/ api/ bin/ extern/ tests/ -name '*.php' | grep -v /examples/ | grep -v /DAO/ | sort | head -n $(( $PG  * $SIZE )) | tail -n $SIZE | xargs phpcbf-civi`
* Go through the diff. For anything that looks wonky, open in an editor and find a better solution.

Note: The automated checker makes good points about awkward indentation, but the automated cleanup often makes it
worse.  So that's why I have to open it up.

[NFC] Reformat tricksy file CRM_Mailing_BAO_Mailing

Method:

* Checkout latest merged branch of civicrm/coder (`8.x-2.x-civi`)
* Run this command to autoclean a batch of 100 files
 `PG=1 SIZE=100 ; find Civi/ CRM/ api/ bin/ extern/ tests/ -name '*.php' | grep -v /examples/ | grep -v /DAO/ | sort | head -n $(( $PG  * $SIZE )) | tail -n $SIZE | xargs phpcbf-civi`
* Go through the diff. For anything that looks wonky, open in an editor and find a better solution

Note: The automated checker makes good points about awkward indentation, but the automated cleanup often makes it
worse.  So that's why I have to open it up.