1. 05 Apr, 2019 2 commits
    • totten's avatar
      (NFC) Apply upcoming civicrm/coder policies (batch 2) · 5d4fcf54
      totten authored
      Method:
      
      * Checkout latest merged branch of civicrm/coder (`8.x-2.x-civi`)
      * Run this command to autoclean a batch of 100 files
        `PG=2 SIZE=100 ; find Civi/ CRM/ api/ bin/ extern/ tests/ -name '*.php' | grep -v /examples/ | grep -v /DAO/ | sort | head -n $(( $PG  * $SIZE )) | tail -n $SIZE | xargs phpcbf-civi`
      * Go through the diff. For anything that looks wonky, open in an editor and find a better solution.
      
      Note: The automated checker makes good points about awkward indentation, but the automated cleanup often makes it
      worse.  So that's why I have to open it up.
      5d4fcf54
    • colemanw's avatar
      Short array syntax - auto-format CRM directory · be2fb01f
      colemanw authored
      be2fb01f
  2. 13 Dec, 2018 1 commit
  3. 19 Apr, 2018 1 commit
    • totten's avatar
      (NFC) Update version in header · fee14197
      totten authored
      This is a simple administrative update to the headers. It was generated with the command:
      
      ```
      rgrep '| CiviCRM version 4.7' CRM/ Civi ang api bin extern install/ settings/ templates -l \
        | xargs sed -i'' "s/| CiviCRM version 4.7/| CiviCRM version 5  /g"
      ```
      
      Tthe inclusion of `|` aimed to avoid matching any non-header text (e.g. inline docs that
      mentioned the version incidentally). But then I did a looser search and for just
      
      ```
      rgrep 'CiviCRM version 4.7'
      ````
      
      and manually patched the remainder.
      
      Note: I'm not really keen on doing this every month, so I relaxed the header
      statement -- instead of `CiviCRM version 5.0`, it's just `CiviCRM version 5`.
      fee14197
  4. 23 Feb, 2018 1 commit
  5. 02 Jan, 2017 1 commit
  6. 21 Mar, 2016 1 commit
  7. 31 Aug, 2015 1 commit
  8. 16 Aug, 2015 1 commit
  9. 27 Mar, 2015 1 commit
  10. 04 Feb, 2015 1 commit
  11. 20 Jan, 2015 2 commits
  12. 18 Jan, 2015 1 commit
  13. 10 Jan, 2015 1 commit
  14. 09 Jan, 2015 2 commits
  15. 31 Dec, 2014 2 commits
    • totten's avatar
      Style - Remove @access · 681aa547
      totten authored
      1. These annotations are useful in PHP4-style code.
      2. These annotations are useless in PHP5-style code. Either they're redundant with the code, or they contradict the code.
      3. In cases where there are contradictions, I don't think there's anyway for us to generally resolve the contradiction except to say, "The code is right."
      4. As a developer reading .php files, I look at the code and *never* look at @access.
      681aa547
    • totten's avatar
      00be9182
  16. 23 Dec, 2014 1 commit
  17. 30 Nov, 2014 1 commit
  18. 28 Mar, 2014 1 commit
  19. 24 Jan, 2014 1 commit
  20. 23 Jan, 2014 1 commit
  21. 15 Aug, 2013 1 commit
  22. 02 Apr, 2013 1 commit
  23. 22 Mar, 2013 1 commit
  24. 01 Mar, 2013 1 commit