1. 07 Apr, 2019 1 commit
  2. 28 Mar, 2019 1 commit
  3. 15 Mar, 2019 1 commit
    • eileen's avatar
      Activity tab performance fix - switch to faster getActivities & getActivitiesCount · 6e793248
      eileen authored
      The getActivitiesCount & getActivities functions are faster & call permission hooks
      but we weren't able to switch to them until we resolved some performance issues
      (done) and resolved acl inconsistencies (resolved in 5.12) -we can do this now.
      
      From a performance POV the difference is tab-crashes vs tab resolves quickly
      on contacts with > 10k activities
      6e793248
  4. 12 Mar, 2019 2 commits
    • eileen's avatar
      Fix relative dates when searching on activity_date_time · 8fc9f99a
      eileen authored
      In testing I found that there is an unreleased regression relating to our date conversion
      on activity_date_time in activity search. This fixes and adds tests. (regression was it
      was being ignored).
      
      Note that the option value is capitalised which makes the capitalisation slightly odd but
      I think accepting that is the least bad option
      8fc9f99a
    • eileen's avatar
      Formatting cleanup · a6b674bb
      eileen authored
      a6b674bb
  5. 04 Feb, 2019 1 commit
    • eileen's avatar
      Performance fix for alternate getActivity listing function · 734f2683
      eileen authored
      We have an alternate function to render the activiy listing on the contact tab. It is
      getActivities whereas the other is deprecatedGetActivities.
      
      It was developed in order to replace the other and we have tests that compare the results of the 2. It is better in that it
      1) performs better (on a  WMF contact with many activities this is 'snappy' while the current deprecated one gives a  white screen time out) and
      2) calls the selectWhereClause hook, allowing hook alteration and respecting preferred architecture.
      
      However, we didn't go live with it in core because it
      1) has a remnant performance bugs (this PR fixes the last of these)
      2) implements ACLs differently - it uses generic functions whereas the deprecated one
      applies more limited permissioning. This is something to clarify & resolve separately.
      
      This PR fixes the last remaining performance issue - best described as
      'When one of the activities to be displayed has many targets the activity listing is slow to load'
      
      The reason for the slowness is that when 'target_contact_name' is passed to the api
      the api does a call for each contact to fetch the contact's sort_name. For a bulk mailing that went to 50,000 people that equates to 50,000 extra queries.
      
      However the actual display shows the first contact name and then gives a number for how many more should be retrieved. This PR hence does not ask the api for the display name, but rather does the check itself, but
      only for 1 target contact rather than ALL
      
      Note that a similar logic might be considered for assignee - I left that out of scope as I'm not
      aware of situations where a large number of assignees would be assigned to a single activity.
      
      The unit test ensures the output matches the deprecated function.
      734f2683
  6. 13 Dec, 2018 1 commit
  7. 13 Aug, 2018 1 commit
  8. 25 Apr, 2018 1 commit
  9. 06 Apr, 2018 2 commits
  10. 13 Mar, 2018 1 commit
  11. 23 Feb, 2018 1 commit
  12. 01 Feb, 2018 1 commit
  13. 18 Jan, 2018 1 commit
  14. 04 Jan, 2018 1 commit
  15. 06 Dec, 2017 1 commit
  16. 20 Nov, 2017 1 commit
  17. 01 Nov, 2017 2 commits
  18. 01 Sep, 2017 1 commit
  19. 01 Jul, 2017 1 commit
  20. 30 Jun, 2017 1 commit
  21. 22 Jun, 2017 2 commits
  22. 08 May, 2017 2 commits
  23. 29 Apr, 2017 1 commit
    • eileen's avatar
      CRM-20481 temporarily switch back while we assess / fix performance. · 7bb73d50
      eileen authored
      We have been seeing performance issues with the use of the api for the dashboard. This is a back-out so
      we can figure that out before re-adding. Note this should not be merged to master as there are
      commits that 'add up to this' in master. There has been some git mistake this round :-(
      
      I'll figure out how to exclude
      7bb73d50
  24. 27 Apr, 2017 2 commits
  25. 26 Apr, 2017 4 commits
  26. 25 Apr, 2017 2 commits
  27. 22 Apr, 2017 1 commit
  28. 16 Apr, 2017 1 commit
  29. 05 Apr, 2017 2 commits