1. 07 Apr, 2019 1 commit
  2. 05 Apr, 2019 4 commits
  3. 04 Apr, 2019 2 commits
  4. 01 Apr, 2019 1 commit
  5. 31 Mar, 2019 1 commit
  6. 28 Mar, 2019 2 commits
  7. 27 Mar, 2019 4 commits
  8. 25 Mar, 2019 2 commits
  9. 24 Mar, 2019 1 commit
  10. 22 Mar, 2019 1 commit
  11. 20 Mar, 2019 1 commit
  12. 19 Mar, 2019 1 commit
  13. 18 Mar, 2019 2 commits
  14. 17 Mar, 2019 2 commits
  15. 15 Mar, 2019 1 commit
    • eileen's avatar
      Activity tab performance fix - switch to faster getActivities & getActivitiesCount · 6e793248
      eileen authored
      The getActivitiesCount & getActivities functions are faster & call permission hooks
      but we weren't able to switch to them until we resolved some performance issues
      (done) and resolved acl inconsistencies (resolved in 5.12) -we can do this now.
      
      From a performance POV the difference is tab-crashes vs tab resolves quickly
      on contacts with > 10k activities
      6e793248
  16. 14 Mar, 2019 1 commit
    • eileen's avatar
      Add unit test to date parsing on import · 1004b689
      eileen authored
      This is primarily as a demo of how to test this class.
      
      Basically extract the parts that we want to check the formatting of into manageable
      functions. I made the name on the second one pretty generic so slowly all formatting can
      be moved into it, with testing.
      
      This would include moving the various bits of work done in
      _civicrm_api3_deprecated_formatted_param
      into this function - that code really does just belong on this class as it
      is not called from anywhere else.
      
      It also does the checking, but not the formatting, for these date fields - sigh
      
      I would have liked to have made the method protected but the mucking around that required
      in the test classes didn't seem to justify it
      1004b689
  17. 12 Mar, 2019 2 commits
    • eileen's avatar
      Fix relative dates when searching on activity_date_time · 8fc9f99a
      eileen authored
      In testing I found that there is an unreleased regression relating to our date conversion
      on activity_date_time in activity search. This fixes and adds tests. (regression was it
      was being ignored).
      
      Note that the option value is capitalised which makes the capitalisation slightly odd but
      I think accepting that is the least bad option
      8fc9f99a
    • eileen's avatar
      Formatting cleanup · a6b674bb
      eileen authored
      a6b674bb
  18. 11 Mar, 2019 1 commit
  19. 05 Mar, 2019 2 commits
  20. 04 Mar, 2019 2 commits
  21. 02 Mar, 2019 1 commit
    • eileen's avatar
      Add upgrade routine to convert on_hold to an array for sites with · b4d67eb2
      eileen authored
      civimail_multiple_bulk_emails set.
      
      with that set we get a select box which needs an array rather than a checkbox.
      
      Note from my testing there is problem loading the defaults due to the field name being
      wrong - this aligns groups created before & after the 5.9 upgrade but does not resolve that.
      
          // preferred communication method
          if (Civi::settings()->get('civimail_multiple_bulk_emails')) {
            ->addSelect('email_on_hold',
              array('entity' => 'email', 'multiple' => 'multiple', 'label' => ts('Email On Hold'), 'options' => CRM_Core_PseudoConstant::emailOnHoldOptions()));
          }
          else {
            ->add('advcheckbox', 'email_on_hold', ts('Email On Hold')
      b4d67eb2
  22. 01 Mar, 2019 2 commits
    • jitendra's avatar
    • eileen's avatar
      Add upgrade routine to convert on_hold to an array for sites with · abe5b62c
      eileen authored
      civimail_multiple_bulk_emails set.
      
      with that set we get a select box which needs an array rather than a checkbox.
      
      Note from my testing there is problem loading the defaults due to the field name being
      wrong - this aligns groups created before & after the 5.9 upgrade but does not resolve that.
      
          // preferred communication method
          if (Civi::settings()->get('civimail_multiple_bulk_emails')) {
            ->addSelect('email_on_hold',
              array('entity' => 'email', 'multiple' => 'multiple', 'label' => ts('Email On Hold'), 'options' => CRM_Core_PseudoConstant::emailOnHoldOptions()));
          }
          else {
            ->add('advcheckbox', 'email_on_hold', ts('Email On Hold')
      abe5b62c
  23. 28 Feb, 2019 1 commit
    • eileen's avatar
      Decommision getPartialPaymentTrxn function · 74e4c3c2
      eileen authored
      This function is only called from one place in the code & also from a test.
      
      It is misleading as it implies a 'get' when it actually does an update
      and it groups functionality in a way that doesn't make sense from the calling code pov
      
      In this commit the function is removed and the lines are directly copied to the calling
      function, as preparation for cleaning up the calling function
      74e4c3c2
  24. 27 Feb, 2019 2 commits