GitLab

Several modules depended on `crmResource` but didn't declare it.

If third-parties are allowed to alter the HTML content, then they may
introduce new dependencies.  This means that they'll need to delcare those
dependencies.

This commit actually moves the declarations for any in-house modules to PHP.

If third-parties are allowed to alter the HTML content, then they may
introduce new dependencies.  This means that they'll need to delcare those
dependencies.

Tangentially, this will also make it easier to construct more optimized
base-pages (e.g.  "make a base-page with module X plus all its
dependencies").

The default behavior is to include a `bundleUrl` for a bundle of "all
Angular modules".  However, some Angular modules like `crmMailing` are only
displayed if the current user has permission to access them.  This means
that the list of "all Angular modules" can be different (depending on who
you are; albeit in practice there's a small# of permutations).

This patch ensures that two users who access a different list of modules
will see a different `bundleUrl`.

Rationale: If the raw HTML can be modified via hook, then the HTML files are
not truly representative of the final output.  (e.g.  a hook might add a new
string to some HTML.)

Note: This patch means that we no longer benefit from the cache in
`CRM_Core_Resources_Strings`.  However, the typical user still pulls data
from a cache because we're using `AssetBuilder` to manage
`angular-modules.json`.

Note: `getStrings()` now requires a call to `getPartials()`, which is
expected to become more expensive (firing a hook).  To avoid building the
partials twice, we introduce a private cache.

In the typical use-case, AssetBuilder can avoid an extra CMS+Civi bootstrap
along with any build steps.

This PR moves the metadata about Angular modules out of Civi\Angular\Manager
and into standalone files (`ang/*.ang.php`).  This uses the same structure
as `civix`.  Also, this makes it easier to navigate between the
JS/HTML/CSS/PHP content.

To test that these changes were safe, I ran the following command before and
after this commit:

$ cv ev 'var_dump(Civi::service("angular")->getModules());'

The results were substantively identical.

CRM-20744 Use images in the bower_components version of datatables plugin rathe…

CRM-20243 Remove outdated sample jquery.min.js from phpword package

CRM-18408 - composer.json - Update ca-config

This loads a more recent build of `cacert.pem` for use on hosts which lack
one.  It does not directly solve CRM-18408, but it complements the solution.

CRM-20561 Use composer for Net_SMTP and Net_Socket and patch for TLS and CiviCR…

CRM-20692: pass through options.

CRM-20740 - Fix issue with check for custom_nn => ['IS NULL' => 1].

CRM-20561 - Remove example files. Cleanup code style.

CRM-19303 - Drupal - Fix computation of `civicrm.files` on multisite

CRM-8597, CRM-20561 - Restore fix for `&`

CRM-20611: fix financial records of cancelled line_items on event fee  change selection 

CRM-20620, optimized code to use Batch api

Fix CRM-20660: Total Opens should count without DISTINCT keyword.

But since I have no working dev environment for the moment, I cannot
run it myself. I will push it, and see if it passes.

(If someone can check whether the tests fails on master, that would
be very nice.)

CRM-20556: Fix datatable warning on merge screen

A few changes:
 * Move logic out of `CRM_Utils_System_Base` to `CRM_Utils_System_DrupalBase`
   so that it's easier to read.
 * Update `[civicrm.files]`:  First, try to use `sites/{$name}/files/civicrm`.
   Otherwise, use `sites/default/files/civicrm`.
    * Note: The `$name` is parsed/validated the same way as `civicrm.config.php`.
      It takes the full HTTP_HOST and then tries various substrings.
 * Update `[civicrm.root]`:  Compare `$civicrm_root` and `cmsRootPath()`
   to determine the relative path.  Then, combine `CIVICRM_UF_BASEURL` with
   relpath.  (This is the same as WordPress.)

CRM-20718 CIVICRM-125 Use the "On behalf of" profile title...

API allows creating multiple addresses same location type

CRM 20672 - Fix access to fields for relationship with target type all contacts in export mapping