diff --git a/CRM/Contribute/BAO/ContributionPage.php b/CRM/Contribute/BAO/ContributionPage.php index 6b1854f0f3b956b864544f2c69e2fb826e0b34e7..346ca886ab16d327b6cc8be930a8543d17f44d3d 100644 --- a/CRM/Contribute/BAO/ContributionPage.php +++ b/CRM/Contribute/BAO/ContributionPage.php @@ -436,15 +436,11 @@ class CRM_Contribute_BAO_ContributionPage extends CRM_Contribute_DAO_Contributio $sendTemplateParams['cc'] = $values['cc_receipt'] ?? NULL; $sendTemplateParams['bcc'] = $values['bcc_receipt'] ?? NULL; //send email with pdf invoice - $template = CRM_Core_Smarty::singleton(); - $taxAmt = $template->get_template_vars('dataArray'); - $isEmailPDF = Civi::settings()->get('invoice_is_email_pdf'); - $invoicing = Civi::settings()->get('invoicing'); - if ($invoicing && !empty($isEmailPDF)) { + if (Civi::settings()->get('invoicing') && Civi::settings()->get('invoice_is_email_pdf')) { $sendTemplateParams['isEmailPdf'] = TRUE; $sendTemplateParams['contributionId'] = $values['contribution_id']; } - list($sent, $subject, $message, $html) = CRM_Core_BAO_MessageTemplate::sendTemplate($sendTemplateParams); + list($sent, $subject, $message) = CRM_Core_BAO_MessageTemplate::sendTemplate($sendTemplateParams); } // send duplicate alert, if dupe match found during on-behalf-of processing. diff --git a/CRM/Contribute/Form/AdditionalInfo.php b/CRM/Contribute/Form/AdditionalInfo.php index f66501a2d3754ff1d2d9bb3fb7f63d51434cfac8..117764dc3a1e5177ad546b1ef9c344525c5cebc8 100644 --- a/CRM/Contribute/Form/AdditionalInfo.php +++ b/CRM/Contribute/Form/AdditionalInfo.php @@ -421,19 +421,7 @@ class CRM_Contribute_Form_AdditionalInfo { $form->assign('receive_date', CRM_Utils_Date::processDate($params['receive_date'])); } - $template = CRM_Core_Smarty::singleton(); - $taxAmt = $template->get_template_vars('dataArray'); - $eventTaxAmt = $template->get_template_vars('totalTaxAmount'); - $prefixValue = Civi::settings()->get('contribution_invoice_settings'); - $invoicing = $prefixValue['invoicing'] ?? NULL; - if ((!empty($taxAmt) || isset($eventTaxAmt)) && (isset($invoicing) && isset($prefixValue['is_email_pdf']))) { - $isEmailPdf = TRUE; - } - else { - $isEmailPdf = FALSE; - } - - list($sendReceipt, $subject, $message, $html) = CRM_Core_BAO_MessageTemplate::sendTemplate( + [$sendReceipt] = CRM_Core_BAO_MessageTemplate::sendTemplate( [ 'groupName' => 'msg_tpl_workflow_contribution', 'valueName' => 'contribution_offline_receipt', @@ -444,7 +432,7 @@ class CRM_Contribute_Form_AdditionalInfo { 'toEmail' => $contributorEmail, 'isTest' => $form->_mode == 'test', 'PDFFilename' => ts('receipt') . '.pdf', - 'isEmailPdf' => $isEmailPdf, + 'isEmailPdf' => Civi::settings()->get('invoicing') && Civi::settings()->get('invoice_is_email_pdf'), ] ); diff --git a/CRM/Event/BAO/Event.php b/CRM/Event/BAO/Event.php index 750d2d372b22fd8814c0cf7072da2c7f3d18adc6..015b2e96609c11125f876c1c7ce576b7f05c2bc5 100644 --- a/CRM/Event/BAO/Event.php +++ b/CRM/Event/BAO/Event.php @@ -1231,10 +1231,8 @@ WHERE civicrm_event.is_active = 1 $sendTemplateParams['bcc'] = CRM_Utils_Array::value('bcc_confirm', $values['event'] ); - // append invoice pdf to email - $prefixValue = Civi::settings()->get('contribution_invoice_settings'); - $invoicing = $prefixValue['invoicing'] ?? NULL; - if (isset($invoicing) && isset($prefixValue['is_email_pdf']) && !empty($values['contributionId'])) { + + if (Civi::settings()->get('invoicing') && Civi::settings()->get('invoice_is_email_pdf') && !empty($values['contributionId'])) { $sendTemplateParams['isEmailPdf'] = TRUE; $sendTemplateParams['contributionId'] = $values['contributionId']; } diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php index 5a1c37eff22cac813fd658458ab062df8ffd5328..1a99a616e9140534fc3eb96690110f85d8709e8f 100644 --- a/CRM/Member/Form/Membership.php +++ b/CRM/Member/Form/Membership.php @@ -970,7 +970,7 @@ DESC limit 1"); 'toName' => $form->_contributorDisplayName, 'toEmail' => $form->_contributorEmail, 'PDFFilename' => ts('receipt') . '.pdf', - 'isEmailPdf' => Civi::settings()->get('invoicing') && Civi::settings()->get('is_email_pdf'), + 'isEmailPdf' => Civi::settings()->get('invoicing') && Civi::settings()->get('invoice_is_email_pdf'), 'contributionId' => $formValues['contribution_id'], 'isTest' => (bool) ($form->_action & CRM_Core_Action::PREVIEW), ]