From cd72683b6747c099858ca1b72fb2ae859dfcbe45 Mon Sep 17 00:00:00 2001
From: Seamus Lee <seamuslee001@gmail.com>
Date: Fri, 4 Jun 2021 22:38:55 +0000
Subject: [PATCH] [php8-compat] Fix issue in APIv3 Where by because product has
 a column called options the testCreateSingleValueAlter triggers a cannot
 access offset of type string on string in php8

---
 api/v3/Generic.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/api/v3/Generic.php b/api/v3/Generic.php
index 586d34f5b98..9a555476073 100644
--- a/api/v3/Generic.php
+++ b/api/v3/Generic.php
@@ -511,7 +511,12 @@ function _civicrm_api3_generic_get_metadata_options(&$metadata, $apiRequest, $fi
     return;
   }
 
-  $fieldsToResolve = $apiRequest['params']['options']['get_options'];
+  if (!is_array($apiRequest['params']['options'])) {
+    $fieldsToResolve = [];
+  }
+  else {
+    $fieldsToResolve = $apiRequest['params']['options']['get_options'];
+  }
 
   if (!empty($metadata[$fieldname]['options']) || (!in_array($fieldname, $fieldsToResolve) && !in_array('all', $fieldsToResolve))) {
     return;
-- 
GitLab