From b4e8c2b4c3f3730a7193824dfb6452b86d5e31d7 Mon Sep 17 00:00:00 2001
From: Patrick Figel <pfigel@greenpeace.org>
Date: Tue, 14 May 2019 15:03:19 +0200
Subject: [PATCH] dev/financial#50 - Fix contributions getting overwritten

This fixes an issue where contributions may be overwritten when users
open an existing contribution after opening the "Record Contribution"
form (but before actually submitting it).
---
 CRM/Contribute/Form/Contribution.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CRM/Contribute/Form/Contribution.php b/CRM/Contribute/Form/Contribution.php
index 0121cd1dbb9..6632df7404a 100644
--- a/CRM/Contribute/Form/Contribution.php
+++ b/CRM/Contribute/Form/Contribution.php
@@ -250,7 +250,7 @@ class CRM_Contribute_Form_Contribution extends CRM_Contribute_Form_AbstractEditP
     $this->assign('action', $this->_action);
 
     // Get the contribution id if update
-    $this->_id = CRM_Utils_Request::retrieve('id', 'Positive', $this);
+    $this->_id = CRM_Utils_Request::retrieve('id', 'Positive');
     if (!empty($this->_id)) {
       $this->assignPaymentInfoBlock();
       $this->assign('contribID', $this->_id);
-- 
GitLab