Commit 8ca36a6e authored by eileen's avatar eileen Committed by JKingsnorth

(towards CRM-19492) Do not assign variables by reference

They are not used as references & this just adds confusion.
parent fa74cac4
......@@ -95,7 +95,7 @@ class CRM_Contact_Form_Merge extends CRM_Core_Form {
}
$this->assign('browseUrl', $browseUrl);
if ($browseUrl) {
$session->pushUserContext($browseUrl);
CRM_Core_Session::singleton()->pushUserContext($browseUrl);
}
$cacheKey = CRM_Dedupe_Merger::getMergeCacheKeyString($this->_rgid, $gid);
......@@ -170,8 +170,8 @@ class CRM_Contact_Form_Merge extends CRM_Core_Form {
$session = CRM_Core_Session::singleton();
$rowsElementsAndInfo = CRM_Dedupe_Merger::getRowsElementsAndInfo($cid, $oid);
$main = $this->_mainDetails = &$rowsElementsAndInfo['main_details'];
$other = $this->_otherDetails = &$rowsElementsAndInfo['other_details'];
$main = $this->_mainDetails = $rowsElementsAndInfo['main_details'];
$other = $this->_otherDetails = $rowsElementsAndInfo['other_details'];
if ($main['contact_id'] != $cid) {
CRM_Core_Error::fatal(ts('The main contact record does not exist'));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment