From 6c1df5dcf2fd90ab5af5ecf742d9b66a50527b6d Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Mon, 12 Oct 2020 10:15:28 +1300
Subject: [PATCH] dev/financial#152 remove unused parameter
---
CRM/Core/Payment/PayPalIPN.php | 3 ---
CRM/Core/Payment/PayPalProIPN.php | 5 +----
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/CRM/Core/Payment/PayPalIPN.php b/CRM/Core/Payment/PayPalIPN.php
index 6f600ccd1db..7024c8a8541 100644
--- a/CRM/Core/Payment/PayPalIPN.php
+++ b/CRM/Core/Payment/PayPalIPN.php
@@ -16,8 +16,6 @@
*/
class CRM_Core_Payment_PayPalIPN extends CRM_Core_Payment_BaseIPN {
- public static $_paymentProcessor = NULL;
-
/**
* Input parameters from payment processor. Store these so that
* the code does not need to keep retrieving from the http request
@@ -329,7 +327,6 @@ class CRM_Core_Payment_PayPalIPN extends CRM_Core_Payment_BaseIPN {
$input['payment_processor_id'] = $paymentProcessorID;
- self::$_paymentProcessor = &$objects['paymentProcessor'];
if ($component == 'contribute') {
if ($ids['contributionRecur']) {
// check if first contribution is completed, else complete first contribution
diff --git a/CRM/Core/Payment/PayPalProIPN.php b/CRM/Core/Payment/PayPalProIPN.php
index 5f4ae129c80..9901c3ea8f7 100644
--- a/CRM/Core/Payment/PayPalProIPN.php
+++ b/CRM/Core/Payment/PayPalProIPN.php
@@ -16,8 +16,6 @@
*/
class CRM_Core_Payment_PayPalProIPN extends CRM_Core_Payment_BaseIPN {
- public static $_paymentProcessor = NULL;
-
/**
* Input parameters from payment processor. Store these so that
* the code does not need to keep retrieving from the http request
@@ -107,7 +105,7 @@ class CRM_Core_Payment_PayPalProIPN extends CRM_Core_Payment_BaseIPN {
// p has been overloaded & could mean contribution page or participant id. Clearly we need an
// alphabet with more letters.
// the mode will always be resolved before the mystery p is reached
- if ($rpValueArray[1] == 'contribute') {
+ if ($rpValueArray[1] === 'contribute') {
$mapping['p'] = 'contribution_page_id';
}
}
@@ -442,7 +440,6 @@ INNER JOIN civicrm_membership_payment mp ON m.id = mp.membership_id AND mp.contr
$input['payment_processor_id'] = $paymentProcessorID;
- self::$_paymentProcessor = &$objects['paymentProcessor'];
//?? how on earth would we not have component be one of these?
// they are the only valid settings & this IPN file can't even be called without one of them
// grepping for this class doesn't find other paths to call this class
--
GitLab