From 51258c34f78787adafcd96f92427cf04de96f3f6 Mon Sep 17 00:00:00 2001
From: Seamus Lee <seamuslee001@gmail.com>
Date: Mon, 27 May 2019 07:30:53 +1000
Subject: [PATCH] dev/core#627 Extend a unit test to verify fix made by Sunil
Add in additional test for when no transactions have occured
---
tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php | 2 ++
tests/phpunit/CRM/Pledge/BAO/PledgeTest.php | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php b/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php
index c02ed249779..fcc0d3a2ba3 100644
--- a/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php
+++ b/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php
@@ -527,6 +527,8 @@ class CRM_Pledge_BAO_PledgePaymentTest extends CiviUnitTestCase {
$this->assertEquals(1, $pp['status_id']);
}
+ $this->assertEquals(count($pledgePayments['values']), CRM_Pledge_BAO_Pledge::pledgeHasFinancialTransactions($pledge->id, 2));
+
// Cleanup
civicrm_api3('Pledge', 'delete', array(
'id' => $pledge->id,
diff --git a/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php b/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php
index 76e2b29fcd9..b29ccbce3d1 100644
--- a/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php
+++ b/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php
@@ -91,6 +91,8 @@ class CRM_Pledge_BAO_PledgeTest extends CiviUnitTestCase {
$this->assertEquals(count($pledgePayment), 1);
$payment = array_pop($pledgePayment);
+ // Assert that we actually have no pledge Payments
+ $this->assertEquals(0, CRM_Pledge_BAO_Pledge::pledgeHasFinancialTransactions($pledge->id, array_search('Pending', CRM_Contribute_PseudoConstant::contributionStatus(NULL, 'name'))));
$this->assertEquals($payment['status'], 'Pending');
$this->assertEquals($payment['scheduled_date'], date('Y-m-d 00:00:00', strtotime($scheduledDate)));
}
--
GitLab