Unverified Commit 40d312e3 authored by Seamus Lee's avatar Seamus Lee Committed by GitHub

Merge pull request #16971 from totten/5.25-seqcredit

financial#84 - Fix upgrade failure. Thin-out activation logic for `sequentialcreditnotes`. 
parents 27a6e10a 8d61bab3
......@@ -75,7 +75,21 @@ class CRM_Upgrade_Incremental_php_FiveTwentyFour extends CRM_Upgrade_Incremental
* @throws \CiviCRM_API3_Exception
*/
public static function installCreditNotes(CRM_Queue_TaskContext $ctx) {
civicrm_api3('Extension', 'install', ['keys' => 'sequentialcreditnotes']);
// Install via direct SQL manipulation. Note that:
// (1) This extension has no activation logic.
// (2) On new installs, the extension is activated purely via default SQL INSERT.
// (3) Caches are flushed at the end of the upgrade.
// ($) Over long term, upgrade steps are more reliable in SQL. API/BAO sometimes don't work mid-upgrade.
$insert = CRM_Utils_SQL_Insert::into('civicrm_extension')->row([
'type' => 'module',
'full_name' => 'sequentialcreditnotes',
'name' => 'Sequential credit notes',
'label' => 'Sequential credit notes',
'file' => 'sequentialcreditnotes',
'schema_version' => NULL,
'is_active' => 1,
]);
CRM_Core_DAO::executeQuery($insert->usingReplace()->toSQL());
return TRUE;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment