From 6b352bfbbc154415b4aab3a755e9cbd5421b7263 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton <emcnaughton@wikimedia.org> Date: Thu, 17 Oct 2019 09:03:42 +1300 Subject: [PATCH] Update Order docs to reflect https://github.com/civicrm/civicrm-core/pull/15514 --- docs/financial/OrderAPI.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/financial/OrderAPI.md b/docs/financial/OrderAPI.md index d943c395..5594f74a 100644 --- a/docs/financial/OrderAPI.md +++ b/docs/financial/OrderAPI.md @@ -17,7 +17,7 @@ If you later remove a line item for a membership or event registration on an upd Do not try to update the status of a contribution, for example to Completed to reflect a payment, either directly or through the Order API. Instead, do a call to the Payment API for an amount that will complete the required payment. This will transition the status of the contribution to Completed and related membership(s) to New or Current and event registration(s). -As a best practice which we intend to require going forward, the `Order.create` should be called with a status of Pending. Then a `Payment.create` should be called to record a payment. +As a best practice the `Order.create` should be called with a status of Pending. Then a `Payment.create` should be called to record a payment. Calling Order.create without "contribution_status_id": "Pending" id deprecated. ## Sample `Order.create` for Simple Contribution @@ -317,8 +317,8 @@ Notes: 3. The `line_item` entry defines the price field and its value. 4. On calling `Payment.create` for this order, the participant's status would be changed to Registered. -!!! bug - Curently you must pass in `"status_id": "Pending from incomplete transaction"` otherwise the participant is created as Registered even before the paymnet has been made. +!!! info + Before 5.20 there was a bug such that you had to pass in `"status_id": "Pending from incomplete transaction"` otherwise the participant was created as Registered even before the paymnet has been made. ## Sample Order.create for 4 line items -- GitLab